Skip to content

Better error messages for usages of ExecutionState::with#219

Merged
jorajeev merged 1 commit intomainfrom
with
Nov 18, 2025
Merged

Better error messages for usages of ExecutionState::with#219
jorajeev merged 1 commit intomainfrom
with

Conversation

@sarsko
Copy link
Copy Markdown
Contributor

@sarsko sarsko commented Oct 8, 2025

I've repeatedly added more logging on usages of ExecutionState::with when debugging stuff, so figured that might as well be there by default.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sarsko sarsko force-pushed the with branch 2 times, most recently from 7628c89 to 82bf5d4 Compare October 8, 2025 23:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Benchmark for e6affc1

Click to view benchmark
Test Base PR %
buffer/pct 285.9±1.96ms 294.1±4.09ms +2.87%
buffer/random 816.6±6.80ms 895.2±4.73ms +9.63%
counter async/pct-narrow 2.1±0.03ms 2.0±0.01ms -4.76%
counter async/pct-wide 21.4±0.16ms 21.4±0.31ms 0.00%
counter async/random-narrow 2.8±0.01ms 2.8±0.01ms 0.00%
counter async/random-wide 9.5±0.08ms 9.3±0.07ms -2.11%
counter scaling async/RW/{tasks:1024,events:100000} 210.5±1.39ms 203.1±0.86ms -3.52%
counter scaling async/RW/{tasks:128,events:100000} 97.4±0.32ms 94.9±0.25ms -2.57%
counter scaling async/RW/{tasks:128,events:10000} 10.7±0.06ms 10.4±0.05ms -2.80%
counter scaling async/RW/{tasks:16,events:100000} 35.9±0.39ms 36.2±0.19ms +0.84%
counter scaling async/RW/{tasks:16,events:10000} 3.9±0.01ms 3.9±0.01ms 0.00%
counter scaling async/RW/{tasks:16,events:1000} 714.4±4.76µs 713.4±5.84µs -0.14%
counter scaling async/RW/{tasks:32,events:100000} 45.6±0.08ms 45.1±0.22ms -1.10%
counter scaling async/RW/{tasks:32,events:10000} 5.2±0.01ms 5.1±0.02ms -1.92%
counter scaling async/RW/{tasks:32,events:1000} 1134.0±11.85µs 1124.6±14.69µs -0.83%
counter scaling async/RW/{tasks:4,events:100000} 25.9±0.06ms 26.1±0.05ms +0.77%
counter scaling async/RW/{tasks:4,events:10000} 2.7±0.01ms 2.7±0.02ms 0.00%
counter scaling async/RW/{tasks:4,events:1000} 370.0±3.49µs 364.5±1.87µs -1.49%
counter scaling async/RW/{tasks:64,events:100000} 63.0±0.23ms 62.1±0.22ms -1.43%
counter scaling async/RW/{tasks:64,events:10000} 7.3±0.03ms 7.2±0.06ms -1.37%
counter scaling async/RW/{tasks:64,events:1000} 1849.8±26.72µs 1821.3±22.93µs -1.54%
counter sync/pct-narrow 2.0±0.01ms 2.0±0.01ms 0.00%
counter sync/pct-wide 21.7±0.16ms 21.3±0.13ms -1.84%
counter sync/random-narrow 2.8±0.01ms 2.8±0.02ms 0.00%
counter sync/random-wide 9.5±0.21ms 9.3±0.06ms -2.11%
create async/pct-narrow 1294.2±17.58µs 1298.4±16.81µs +0.32%
create async/pct-wide 37.5±0.15ms 37.7±0.14ms +0.53%
create async/random-narrow 1387.6±7.42µs 1302.0±25.93µs -6.17%
create async/random-wide 20.1±0.18ms 20.2±0.08ms +0.50%
create sync/pct-narrow 1412.5±20.54µs 1409.7±28.85µs -0.20%
create sync/pct-wide 36.8±0.14ms 36.6±0.14ms -0.54%
create sync/random-narrow 1210.0±14.85µs 1202.6±12.85µs -0.61%
create sync/random-wide 20.3±0.12ms 19.9±0.27ms -1.97%
lock scaling sync/RW/{tasks:1024,events:100000} 302.2±1.33s 318.8±1.24s +5.49%
lock scaling sync/RW/{tasks:128,events:100000} 38.6±0.18s 40.9±0.20s +5.96%
lock scaling sync/RW/{tasks:128,events:10000} 3.6±0.02s 3.9±0.02s +8.33%
lock scaling sync/RW/{tasks:16,events:100000} 4.3±0.02s 4.5±0.02s +4.65%
lock scaling sync/RW/{tasks:16,events:10000} 429.9±2.14ms 446.6±2.64ms +3.88%
lock scaling sync/RW/{tasks:16,events:1000} 40.0±0.16ms 41.6±0.24ms +4.00%
lock scaling sync/RW/{tasks:32,events:100000} 9.3±0.06s 9.7±0.04s +4.30%
lock scaling sync/RW/{tasks:32,events:10000} 898.6±4.55ms 944.3±5.84ms +5.09%
lock scaling sync/RW/{tasks:32,events:1000} 83.1±0.34ms 87.4±0.57ms +5.17%
lock scaling sync/RW/{tasks:4,events:100000} 717.9±2.10ms 743.0±3.71ms +3.50%
lock scaling sync/RW/{tasks:4,events:10000} 71.1±0.10ms 73.9±0.30ms +3.94%
lock scaling sync/RW/{tasks:4,events:1000} 7.1±0.02ms 7.3±0.03ms +2.82%
lock scaling sync/RW/{tasks:64,events:100000} 19.0±0.09s 20.1±0.10s +5.79%
lock scaling sync/RW/{tasks:64,events:10000} 1818.0±11.46ms 1928.9±15.69ms +6.10%
lock scaling sync/RW/{tasks:64,events:1000} 154.2±0.94ms 162.5±1.08ms +5.38%
lock sync/pct-narrow 3.0±0.07ms 3.1±0.05ms +3.33%
lock sync/pct-wide 22.6±0.16ms 22.6±0.10ms 0.00%
lock sync/random-narrow 100.5±0.60ms 103.1±0.52ms +2.59%
lock sync/random-wide 2.9±0.03s 3.0±0.02s +3.45%

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Benchmark for b2f33bb

Click to view benchmark
Test Base PR %
buffer/pct 289.7±1.70ms 292.4±4.02ms +0.93%
buffer/random 831.9±6.69ms 892.7±5.04ms +7.31%
counter async/pct-narrow 2.0±0.07ms 2.0±0.01ms 0.00%
counter async/pct-wide 21.4±0.15ms 21.4±0.18ms 0.00%
counter async/random-narrow 2.9±0.02ms 2.8±0.02ms -3.45%
counter async/random-wide 9.4±0.07ms 9.3±0.08ms -1.06%
counter scaling async/RW/{tasks:1024,events:100000} 209.7±0.96ms 202.7±3.78ms -3.34%
counter scaling async/RW/{tasks:128,events:100000} 97.4±0.34ms 95.2±0.97ms -2.26%
counter scaling async/RW/{tasks:128,events:10000} 10.7±0.06ms 10.5±0.08ms -1.87%
counter scaling async/RW/{tasks:16,events:100000} 35.8±0.12ms 36.2±0.45ms +1.12%
counter scaling async/RW/{tasks:16,events:10000} 3.9±0.07ms 3.9±0.01ms 0.00%
counter scaling async/RW/{tasks:16,events:1000} 714.3±7.58µs 720.0±5.05µs +0.80%
counter scaling async/RW/{tasks:32,events:100000} 45.6±0.08ms 45.5±0.13ms -0.22%
counter scaling async/RW/{tasks:32,events:10000} 5.2±0.01ms 5.1±0.02ms -1.92%
counter scaling async/RW/{tasks:32,events:1000} 1118.6±15.40µs 1129.9±15.18µs +1.01%
counter scaling async/RW/{tasks:4,events:100000} 25.9±0.11ms 26.0±0.03ms +0.39%
counter scaling async/RW/{tasks:4,events:10000} 2.7±0.01ms 2.7±0.00ms 0.00%
counter scaling async/RW/{tasks:4,events:1000} 369.3±2.76µs 379.2±4.84µs +2.68%
counter scaling async/RW/{tasks:64,events:100000} 63.5±0.61ms 62.1±0.13ms -2.20%
counter scaling async/RW/{tasks:64,events:10000} 7.4±0.04ms 7.3±0.28ms -1.35%
counter scaling async/RW/{tasks:64,events:1000} 1851.2±23.94µs 1823.4±22.48µs -1.50%
counter sync/pct-narrow 2.0±0.01ms 2.0±0.06ms 0.00%
counter sync/pct-wide 21.3±0.09ms 21.3±0.45ms 0.00%
counter sync/random-narrow 2.8±0.07ms 2.8±0.01ms 0.00%
counter sync/random-wide 9.4±0.17ms 9.3±0.08ms -1.06%
create async/pct-narrow 1298.9±32.38µs 1331.7±9.96µs +2.53%
create async/pct-wide 38.4±0.39ms 37.9±0.44ms -1.30%
create async/random-narrow 1284.1±21.60µs 1313.9±11.31µs +2.32%
create async/random-wide 20.8±0.08ms 20.3±0.10ms -2.40%
create sync/pct-narrow 1419.0±23.71µs 1425.9±9.09µs +0.49%
create sync/pct-wide 38.5±0.85ms 36.7±0.13ms -4.68%
create sync/random-narrow 1222.0±16.38µs 1240.7±116.34µs +1.53%
create sync/random-wide 21.2±0.10ms 19.8±0.09ms -6.60%
lock scaling sync/RW/{tasks:1024,events:100000} 302.0±0.96s 321.9±1.86s +6.59%
lock scaling sync/RW/{tasks:128,events:100000} 38.5±0.13s 41.1±0.22s +6.75%
lock scaling sync/RW/{tasks:128,events:10000} 3.6±0.02s 3.9±0.02s +8.33%
lock scaling sync/RW/{tasks:16,events:100000} 4.3±0.03s 4.6±0.01s +6.98%
lock scaling sync/RW/{tasks:16,events:10000} 428.9±1.21ms 456.9±6.85ms +6.53%
lock scaling sync/RW/{tasks:16,events:1000} 39.3±0.14ms 42.3±0.24ms +7.63%
lock scaling sync/RW/{tasks:32,events:100000} 9.2±0.04s 9.9±0.05s +7.61%
lock scaling sync/RW/{tasks:32,events:10000} 885.8±6.34ms 960.3±4.83ms +8.41%
lock scaling sync/RW/{tasks:32,events:1000} 82.0±0.51ms 89.1±0.36ms +8.66%
lock scaling sync/RW/{tasks:4,events:100000} 713.4±5.57ms 752.5±3.25ms +5.48%
lock scaling sync/RW/{tasks:4,events:10000} 70.8±0.47ms 74.9±0.22ms +5.79%
lock scaling sync/RW/{tasks:4,events:1000} 7.0±0.03ms 7.5±0.02ms +7.14%
lock scaling sync/RW/{tasks:64,events:100000} 19.1±0.09s 20.3±0.15s +6.28%
lock scaling sync/RW/{tasks:64,events:10000} 1822.7±16.61ms 1951.3±13.85ms +7.06%
lock scaling sync/RW/{tasks:64,events:1000} 154.3±3.76ms 164.0±1.04ms +6.29%
lock sync/pct-narrow 3.0±0.02ms 3.1±0.01ms +3.33%
lock sync/pct-wide 22.6±0.16ms 22.6±0.11ms 0.00%
lock sync/random-narrow 99.2±0.45ms 105.5±0.65ms +6.35%
lock sync/random-wide 2.9±0.02s 3.1±0.03s +6.90%

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Benchmark for 1f28786

Click to view benchmark
Test Base PR %
buffer/pct 286.8±1.40ms 291.0±3.92ms +1.46%
buffer/random 827.9±5.70ms 887.7±4.50ms +7.22%
counter async/pct-narrow 1995.4±9.19µs 2.0±0.01ms +0.23%
counter async/pct-wide 21.3±0.12ms 21.2±0.14ms -0.47%
counter async/random-narrow 2.8±0.01ms 2.8±0.01ms 0.00%
counter async/random-wide 9.5±0.07ms 9.3±0.07ms -2.11%
counter scaling async/RW/{tasks:1024,events:100000} 209.5±0.43ms 198.3±0.59ms -5.35%
counter scaling async/RW/{tasks:128,events:100000} 97.3±0.26ms 94.3±0.18ms -3.08%
counter scaling async/RW/{tasks:128,events:10000} 10.6±0.06ms 10.4±0.05ms -1.89%
counter scaling async/RW/{tasks:16,events:100000} 36.2±0.08ms 35.8±0.09ms -1.10%
counter scaling async/RW/{tasks:16,events:10000} 3.9±0.01ms 3.9±0.04ms 0.00%
counter scaling async/RW/{tasks:16,events:1000} 712.8±7.80µs 715.0±6.69µs +0.31%
counter scaling async/RW/{tasks:32,events:100000} 44.9±0.09ms 44.8±0.15ms -0.22%
counter scaling async/RW/{tasks:32,events:10000} 5.1±0.01ms 5.1±0.01ms 0.00%
counter scaling async/RW/{tasks:32,events:1000} 1120.4±13.52µs 1128.1±13.19µs +0.69%
counter scaling async/RW/{tasks:4,events:100000} 26.3±0.03ms 26.3±0.04ms 0.00%
counter scaling async/RW/{tasks:4,events:10000} 2.7±0.01ms 2.8±0.03ms +3.70%
counter scaling async/RW/{tasks:4,events:1000} 370.5±1.95µs 373.7±1.69µs +0.86%
counter scaling async/RW/{tasks:64,events:100000} 63.4±0.32ms 61.7±0.07ms -2.68%
counter scaling async/RW/{tasks:64,events:10000} 7.4±0.03ms 7.2±0.09ms -2.70%
counter scaling async/RW/{tasks:64,events:1000} 1825.2±32.79µs 1839.4±21.88µs +0.78%
counter sync/pct-narrow 1996.8±4.70µs 2.0±0.03ms +0.16%
counter sync/pct-wide 21.4±0.17ms 21.2±0.12ms -0.93%
counter sync/random-narrow 2.9±0.01ms 2.9±0.01ms 0.00%
counter sync/random-wide 9.4±0.06ms 9.3±0.08ms -1.06%
create async/pct-narrow 1325.3±25.95µs 1304.4±17.29µs -1.58%
create async/pct-wide 37.6±0.14ms 37.9±0.14ms +0.80%
create async/random-narrow 1310.6±22.19µs 1297.8±23.05µs -0.98%
create async/random-wide 20.2±0.09ms 20.2±0.12ms 0.00%
create sync/pct-narrow 1444.9±8.17µs 1408.5±21.93µs -2.52%
create sync/pct-wide 36.9±0.19ms 36.6±0.15ms -0.81%
create sync/random-narrow 1231.9±16.51µs 1208.1±15.02µs -1.93%
create sync/random-wide 20.5±0.07ms 19.8±0.30ms -3.41%
lock scaling sync/RW/{tasks:1024,events:100000} 299.8±1.63s 321.3±1.27s +7.17%
lock scaling sync/RW/{tasks:128,events:100000} 38.5±0.23s 41.1±0.17s +6.75%
lock scaling sync/RW/{tasks:128,events:10000} 3.6±0.02s 3.9±0.03s +8.33%
lock scaling sync/RW/{tasks:16,events:100000} 4.3±0.02s 4.7±0.05s +9.30%
lock scaling sync/RW/{tasks:16,events:10000} 425.8±2.67ms 458.0±3.71ms +7.56%
lock scaling sync/RW/{tasks:16,events:1000} 39.5±0.26ms 42.5±0.20ms +7.59%
lock scaling sync/RW/{tasks:32,events:100000} 9.3±0.05s 9.9±0.05s +6.45%
lock scaling sync/RW/{tasks:32,events:10000} 893.1±5.04ms 964.1±7.23ms +7.95%
lock scaling sync/RW/{tasks:32,events:1000} 83.1±0.45ms 88.8±0.44ms +6.86%
lock scaling sync/RW/{tasks:4,events:100000} 716.5±2.59ms 758.1±6.89ms +5.81%
lock scaling sync/RW/{tasks:4,events:10000} 70.6±0.29ms 75.6±0.65ms +7.08%
lock scaling sync/RW/{tasks:4,events:1000} 7.0±0.03ms 7.5±0.03ms +7.14%
lock scaling sync/RW/{tasks:64,events:100000} 19.0±0.14s 20.4±0.11s +7.37%
lock scaling sync/RW/{tasks:64,events:10000} 1820.4±15.67ms 1952.4±21.64ms +7.25%
lock scaling sync/RW/{tasks:64,events:1000} 152.0±0.88ms 163.7±0.66ms +7.70%
lock sync/pct-narrow 3.1±0.01ms 3.1±0.02ms 0.00%
lock sync/pct-wide 22.5±0.19ms 22.3±0.11ms -0.89%
lock sync/random-narrow 98.9±0.48ms 105.1±1.36ms +6.27%
lock sync/random-wide 2.8±0.03s 3.1±0.03s +10.71%

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Benchmark for eceba6b

Click to view benchmark
Test Base PR %
buffer/pct 283.9±1.46ms 291.5±5.41ms +2.68%
buffer/random 823.2±6.46ms 886.0±3.77ms +7.63%
counter async/pct-narrow 2.0±0.09ms 2.0±0.01ms 0.00%
counter async/pct-wide 21.6±0.21ms 21.4±0.17ms -0.93%
counter async/random-narrow 2.8±0.01ms 2.8±0.01ms 0.00%
counter async/random-wide 9.5±0.08ms 9.3±0.08ms -2.11%
counter scaling async/RW/{tasks:1024,events:100000} 211.1±1.19ms 203.1±0.77ms -3.79%
counter scaling async/RW/{tasks:128,events:100000} 97.5±0.24ms 94.7±0.24ms -2.87%
counter scaling async/RW/{tasks:128,events:10000} 10.8±0.07ms 10.4±0.05ms -3.70%
counter scaling async/RW/{tasks:16,events:100000} 36.3±0.12ms 35.9±0.10ms -1.10%
counter scaling async/RW/{tasks:16,events:10000} 4.0±0.01ms 3.9±0.01ms -2.50%
counter scaling async/RW/{tasks:16,events:1000} 719.3±7.15µs 715.9±5.30µs -0.47%
counter scaling async/RW/{tasks:32,events:100000} 45.8±0.21ms 45.2±0.14ms -1.31%
counter scaling async/RW/{tasks:32,events:10000} 5.2±0.01ms 5.1±0.01ms -1.92%
counter scaling async/RW/{tasks:32,events:1000} 1130.1±15.51µs 1130.4±14.25µs +0.03%
counter scaling async/RW/{tasks:4,events:100000} 26.0±0.05ms 26.3±0.07ms +1.15%
counter scaling async/RW/{tasks:4,events:10000} 2.7±0.01ms 2.8±0.01ms +3.70%
counter scaling async/RW/{tasks:4,events:1000} 373.8±2.93µs 372.3±3.63µs -0.40%
counter scaling async/RW/{tasks:64,events:100000} 63.3±0.17ms 62.3±0.94ms -1.58%
counter scaling async/RW/{tasks:64,events:10000} 7.4±0.04ms 7.3±0.06ms -1.35%
counter scaling async/RW/{tasks:64,events:1000} 1857.0±24.10µs 1824.9±22.02µs -1.73%
counter sync/pct-narrow 2.0±0.00ms 2.0±0.01ms 0.00%
counter sync/pct-wide 21.7±0.17ms 21.3±0.13ms -1.84%
counter sync/random-narrow 2.8±0.01ms 2.9±0.01ms +3.57%
counter sync/random-wide 9.5±0.07ms 9.3±0.08ms -2.11%
create async/pct-narrow 1308.6±10.72µs 1333.9±30.26µs +1.93%
create async/pct-wide 38.0±0.13ms 38.1±0.16ms +0.26%
create async/random-narrow 1300.9±9.36µs 1335.1±14.92µs +2.63%
create async/random-wide 20.6±0.08ms 20.3±0.09ms -1.46%
create sync/pct-narrow 1427.1±22.28µs 1442.4±21.01µs +1.07%
create sync/pct-wide 37.0±0.16ms 36.8±0.13ms -0.54%
create sync/random-narrow 1222.6±17.40µs 1248.8±23.55µs +2.14%
create sync/random-wide 20.7±0.10ms 20.0±0.11ms -3.38%
lock scaling sync/RW/{tasks:1024,events:100000} 300.9±1.31s 320.4±0.97s +6.48%
lock scaling sync/RW/{tasks:128,events:100000} 38.5±0.19s 40.9±0.30s +6.23%
lock scaling sync/RW/{tasks:128,events:10000} 3.6±0.03s 3.9±0.02s +8.33%
lock scaling sync/RW/{tasks:16,events:100000} 4.3±0.02s 4.6±0.03s +6.98%
lock scaling sync/RW/{tasks:16,events:10000} 419.0±1.76ms 449.3±2.90ms +7.23%
lock scaling sync/RW/{tasks:16,events:1000} 39.1±0.09ms 42.1±0.23ms +7.67%
lock scaling sync/RW/{tasks:32,events:100000} 9.2±0.06s 9.8±0.04s +6.52%
lock scaling sync/RW/{tasks:32,events:10000} 888.0±4.17ms 948.5±6.88ms +6.81%
lock scaling sync/RW/{tasks:32,events:1000} 82.0±0.23ms 88.3±0.18ms +7.68%
lock scaling sync/RW/{tasks:4,events:100000} 708.6±2.96ms 749.5±4.20ms +5.77%
lock scaling sync/RW/{tasks:4,events:10000} 70.4±0.57ms 74.5±0.38ms +5.82%
lock scaling sync/RW/{tasks:4,events:1000} 7.0±0.02ms 7.4±0.04ms +5.71%
lock scaling sync/RW/{tasks:64,events:100000} 18.9±0.11s 20.1±0.14s +6.35%
lock scaling sync/RW/{tasks:64,events:10000} 1807.6±14.42ms 1941.6±15.27ms +7.41%
lock scaling sync/RW/{tasks:64,events:1000} 151.6±0.74ms 162.5±0.75ms +7.19%
lock sync/pct-narrow 3.0±0.06ms 3.1±0.02ms +3.33%
lock sync/pct-wide 22.6±0.18ms 22.3±0.19ms -1.33%
lock sync/random-narrow 98.8±0.57ms 104.8±0.56ms +6.07%
lock sync/random-wide 2.8±0.02s 3.0±0.02s +7.14%

@jorajeev jorajeev merged commit ccb4141 into main Nov 18, 2025
7 checks passed
@sarsko sarsko deleted the with branch November 26, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants