Use Level::ERROR for all tracing spans#24
Merged
Conversation
The level of the span determines when it will be included in tracing output: a span at level TRACE will only be included in messages at level TRACE, a span at level INFO will be included in messages at level INFO or lower, etc. So we want to put these spans at level ERROR to include them in *all* output. The idea is that Shuttle users can use e.g. `tracing::info!` in their program to debug, and those messages will include the span info (most importantly, the task ID) from Shuttle.
jorajeev
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The level of the span determines when it will be included in tracing output:
a span at level TRACE will only be included in messages at level TRACE, a span
at level INFO will be included in messages at level INFO or lower, etc. So we
want to put these spans at level ERROR to include them in all output. The
idea is that Shuttle users can use e.g.
tracing::info!in their program todebug, and those messages will include the span info (most importantly, the
task ID) from Shuttle.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.