[Tracer] Add flatten argument to .trace()#29
Merged
comaniac merged 4 commits intoawslabs:mainfrom Jan 31, 2023
Merged
Conversation
Contributor
|
Oh btw, you may need to update README. |
Contributor
Author
|
Which part? The current README has already presented the |
Contributor
|
I didn't notice that...then it's good to go. |
Contributor
|
Thanks @chhzh123 |
This was referenced Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
flattenargument to the.trace()primitive, so users can determine whether they want the traced graph to be flattened or not. Combining withleaf_module, users can have fine-grained control on how many and which levels of submodules they want to be flattened or hierarchical. For example, to only flatten theBertAttentionlayer but not the innerBertSelfAttentionandBertSelfOutputmodules, users can write the following code.As shown below, only
attention.selfandattention.outputare generated in the dataflow graph, but not the innerattention.self.query/key/valuelayers.Checklist