[Bugfix] Fix for sharding TP only#32
Merged
comaniac merged 7 commits intoawslabs:mainfrom Feb 1, 2023
Merged
Conversation
comaniac
reviewed
Jan 31, 2023
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
added 3 commits
January 31, 2023 22:49
Contributor
|
Thanks @zarzen |
Contributor
|
Found that this PR breaks 3D scripts (which are not covered in CI yet). @zarzen please file a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ParallelCrossEntropyas the loss instead of the loss from HF.mpuas input to thedeespeed.initialize(...)function.--disable_pipelineis used for disabling pipeline parallelism, we need to get thenum_mpparameters from theargs.Known issue
Checklist