[Bugfix] Using None for mpu when PP > 1#34
Merged
szhengac merged 2 commits intoawslabs:mainfrom Feb 1, 2023
Merged
Conversation
added 2 commits
February 1, 2023 01:53
comaniac
approved these changes
Feb 1, 2023
szhengac
reviewed
Feb 1, 2023
| mpu = kwargs.get("topology", None) | ||
| if mpu is not None and isinstance(mpu, PipeModelDataParallelTopology): | ||
| mpu = PipelineParallelGrid(topology=mpu) | ||
| if mpu.get_dim("pipe") <= 1: |
Contributor
Author
There was a problem hiding this comment.
Not really, just for separating the conditions for pipeline and no pipeline in a binary form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mpugrid to avoid initialization errorChecklist