[Schedule] Refactor subgraph matching#35
Merged
comaniac merged 21 commits intoawslabs:mainfrom Feb 1, 2023
Merged
Conversation
5 tasks
Contributor
|
Nice done. Will review tomorrow. |
comaniac
reviewed
Feb 1, 2023
Contributor
comaniac
left a comment
There was a problem hiding this comment.
Overall LGTM. Just need some minor refactors.
c27ecfd to
8addb36
Compare
comaniac
approved these changes
Feb 1, 2023
Contributor
comaniac
left a comment
There was a problem hiding this comment.
LGTM.
nit:
Returns
----------
Should be
Returns
-------
But you could fix it in later PRs.
Contributor
|
Thanks @chhzh123 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the subgraph matching API and changes it to
s.find(regex_or_pattern_fn)that is presented in the paper. Also, it adds support for more general patterns (e.g., subgraphs with multiple input arguments). A lightweight pattern language is also proposed to support fuzzy matching.Basically, there are several use cases:
By leveraging the pattern language, we can express complex patterns in a very simple way, like the below horizontal QKV example.
Checklist
cc @comaniac