[Tracer] Remove SelfAttention renaming#44
Merged
comaniac merged 1 commit intoawslabs:mainfrom Feb 7, 2023
Merged
Conversation
comaniac
reviewed
Feb 7, 2023
Comment on lines
+41
to
+43
| logger.warning( | ||
| "`self` in {root.__class__.__name__} is a Python keyword, please rename it to avoid possible conflicts." | ||
| ) |
Contributor
There was a problem hiding this comment.
This is just a warning. What happen if we keep running?
Contributor
Author
There was a problem hiding this comment.
I tested the traced module and it can execute normally. If we only call the SelfAttention module with the self prefix, it seems to work. I forget why at the first place I met the naming error, which was probably related to the previous implementation of the tracer.
class Model(nn.Module):
def __init__(self):
self.self = ...
def forward(self, x):
x = self.self(x)
...
comaniac
approved these changes
Feb 7, 2023
Contributor
|
Thanks @chhzh123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #13 and #30 by removing the legacy code of renaming self attention module for HuggingFace models. As now we only trace the module when needed and also replace the attention module with our own module, the naming issue probably may not be a problem. We also do not refer to
self_min our example schedules, so I remove the renaming part from the tracer, and only prompt a warning when the tracer meets thoseselfmodules.Checklist
cc @szhengac @comaniac