Skip to content

Fix transformers import order in megatron scripts#5

Merged
chhzh123 merged 1 commit intoawslabs:mainfrom
szhengac:megatron
Jan 19, 2023
Merged

Fix transformers import order in megatron scripts#5
chhzh123 merged 1 commit intoawslabs:mainfrom
szhengac:megatron

Conversation

@szhengac
Copy link
Contributor

Description

import transformers needs to be placed before import megatron, otherwise we will receive segfault for more recent transformers.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhzh123 chhzh123 merged commit f868eb8 into awslabs:main Jan 19, 2023
chhzh123 pushed a commit to chhzh123/slapo that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants