Skip to content

[Examples] Move examples to slapo.model_schedule#53

Merged
chhzh123 merged 42 commits intoawslabs:mainfrom
chhzh123:model_schedule
Feb 15, 2023
Merged

[Examples] Move examples to slapo.model_schedule#53
chhzh123 merged 42 commits intoawslabs:mainfrom
chhzh123:model_schedule

Conversation

@chhzh123
Copy link
Contributor

Description

This PR moves the schedules in the example models to slapo.model_schedule, so users can easily retrieve the scheduled models.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@chhzh123 chhzh123 mentioned this pull request Feb 11, 2023
4 tasks
@chhzh123
Copy link
Contributor Author

The epoi is removed? It seems the test failed because of the package dependency. @comaniac

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. We could later design an API to dispatch the right "schedule_model" function based on the given model.

@comaniac
Copy link
Contributor

The epoi is removed? It seems the test failed because of the package dependency. @comaniac

It should still be there or unit tests will fail. I'm not sure why there's a lint error tho...

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhzh123
Copy link
Contributor Author

I'm still changing the API. Will let you know when I'm done. @comaniac

@chhzh123
Copy link
Contributor Author

Added apply_schedule(model, model_config, sch_config) API.

@chhzh123 chhzh123 requested a review from comaniac February 12, 2023 20:44
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need an offline discussion on Monday about the APIs.

@chhzh123 chhzh123 requested a review from comaniac February 14, 2023 07:31
@chhzh123
Copy link
Contributor Author

I've refactored all the code and changed the API to apply_schedule(model, schedule_key, **schedule_config). Should be ready to review. @comaniac

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last batch of comments.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discussion this PR still needs to fix GPT-2 schedule.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chhzh123 I'll leave this PR to you for the final check and merge. Thanks.

@chhzh123
Copy link
Contributor Author

I've tested. Thanks @comaniac.

@chhzh123 chhzh123 merged commit c2ac90a into awslabs:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants