[Examples] Move examples to slapo.model_schedule#53
Conversation
|
The epoi is removed? It seems the test failed because of the package dependency. @comaniac |
comaniac
left a comment
There was a problem hiding this comment.
Otherwise LGTM. We could later design an API to dispatch the right "schedule_model" function based on the given model.
It should still be there or unit tests will fail. I'm not sure why there's a lint error tho... |
|
I'm still changing the API. Will let you know when I'm done. @comaniac |
|
Added |
comaniac
left a comment
There was a problem hiding this comment.
We probably need an offline discussion on Monday about the APIs.
e13e8b5 to
b31e902
Compare
|
I've refactored all the code and changed the API to |
comaniac
left a comment
There was a problem hiding this comment.
Should be the last batch of comments.
comaniac
left a comment
There was a problem hiding this comment.
Per offline discussion this PR still needs to fix GPT-2 schedule.
|
I've tested. Thanks @comaniac. |
Description
This PR moves the schedules in the example models to
slapo.model_schedule, so users can easily retrieve the scheduled models.Checklist