Skip to content

[Bugfix] Fix a small device bug#57

Merged
comaniac merged 6 commits intoawslabs:mainfrom
szhengac:device
Feb 16, 2023
Merged

[Bugfix] Fix a small device bug#57
comaniac merged 6 commits intoawslabs:mainfrom
szhengac:device

Conversation

@szhengac
Copy link
Contributor

Initialize all-gather tensor on gpu.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@chhzh123
Copy link
Contributor

This line also uses .to(device). Maybe we can also change it?
https://github.com/awslabs/slapo/blob/main/slapo/framework_dialect/deepspeed/pipeline.py#L320

@szhengac
Copy link
Contributor Author

This line also uses .to(device). Maybe we can also change it? https://github.com/awslabs/slapo/blob/main/slapo/framework_dialect/deepspeed/pipeline.py#L320

Nice catch!

@comaniac comaniac merged commit a82f501 into awslabs:main Feb 16, 2023
@comaniac
Copy link
Contributor

Thanks @szhengac @chhzh123

@szhengac szhengac deleted the device branch February 16, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants