[Bugfix] Consolidate params with orig size#59
Merged
comaniac merged 2 commits intoawslabs:mainfrom Feb 15, 2023
Merged
Conversation
szhengac
reviewed
Feb 15, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we use
sch.metadata.base_paramsto maintain the original parameter shape before sharding. However, the scope of schedule metadata is limited to the current schedule and won't be transferred if.replaceis used, sosch.metadata.base_paramswon't be correct anymore in this case.In this PR, we removed
sch.metadata.base_paramsand directly set an attribute to sharded parameters to record their original shapes. In future, we should revisit thesch.metadatadesign.Checklist
cc @szhengac @chhzh123