[Primitive][fork_rng] Do not replace module#76
Merged
comaniac merged 2 commits intoawslabs:mainfrom Mar 8, 2023
Merged
Conversation
Contributor
Author
|
Thanks @chhzh123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way of implementing
.fork_rng(). Now it replaces the forward function instead of an entire module. However, this approach results in incorrect trace results. Specifically, this module can still be traced, but the traced graph is based on the original forward function, which is incorrect. As a result, this PR also introduces an internal attribute.traceabletonn.Module, and we check this attribute to determine whether a Slapo customized module is traceable.Checklist
cc @chhzh123