Avoid reflective copying in SqsContainerOptions builder#1609
Open
sondemar wants to merge 1 commit intoawspring:mainfrom
Open
Avoid reflective copying in SqsContainerOptions builder#1609sondemar wants to merge 1 commit intoawspring:mainfrom
sondemar wants to merge 1 commit intoawspring:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Replace reflective builder state copying in
SqsContainerOptionswith explicit field copying.This change updates the SQS container options builder copy paths to avoid
ReflectionUtils.shallowCopyFieldState(...)and preserve custommessageConverterconfiguration when options are copied through builder/container creation flows.It also adds regression tests for:
createCopy()fromBuilder(...)SqsMessageListenerContainerFactory💡 Motivation and Context
This fixes the issue where custom
messageConverterconfiguration could be lost or behave incorrectly whenSqsContainerOptionswere copied.It also removes reflection from this builder-copy path, which is a better fit for AOT/native scenarios.
Fixes #1598
💚 How did you test it?
Ran focused SQS tests covering the changed code paths:
mvn -o -pl spring-cloud-aws-sqs -Dtest=ContainerOptionsTests,SqsMessageListenerContainerFactoryTests testAlso verified the project still packages successfully with tests skipped:
mvn -o -DskipTests clean package📝 Checklist
🔮 Next steps
None.