Relax prefix validation rules in Parameter Store and Secrets Manager #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejNedic
requested review from
eddumelendez and
maciejwalkowiak
as code owners
github-actions
bot
added
component: parameter-store
maciejwalkowiak
requested changes
Apr 9, 2022
...ter-store-config/src/test/java/io/awspring/cloud/paramstore/AwsParamStorePropertiesTest.java
Outdated
Show resolved
Hide resolved
...ter-store-config/src/test/java/io/awspring/cloud/paramstore/AwsParamStorePropertiesTest.java
Outdated
Show resolved
Hide resolved
| * Pattern used for prefix validation. | ||
| */ | ||
| private static final Pattern PREFIX_PATTERN = Pattern.compile("(/)?([a-zA-Z0-9.\\-]+)(?:/[a-zA-Z0-9]+)*"); | ||
| private static final Pattern PREFIX_PATTERN = Pattern.compile("(/)?([a-zA-Z0-9.\\-]+)(?:/[a-zA-Z0-9.\\-]+)*"); |
Contributor
There was a problem hiding this comment.
I am wondering if it couldn't be simply [a-zA-Z0-9.\-/]+..?
maciejwalkowiak
changed the title
|
SonarCloud Quality Gate failed.
|
padilo
pushed a commit
to padilo/spring-cloud-aws
that referenced
this pull request
May 2, 2022
…wspring#303) Fixes awspring#302 Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
#302
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps