Skip to content

Conversation

@padilo
Copy link

@padilo padilo commented May 2, 2022

Applies PR #303 for 2.3.x, basically it was a cherry-pick and check that tests passes

All credits to Maciej Walkowiak @MatejNedic

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

…wspring#303)

Fixes awspring#302 
Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
@github-actions github-actions bot added component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue labels May 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@padilo
Copy link
Author

padilo commented May 2, 2022

It could be nice if this is approved if you could release a 2.3.5

@maciejwalkowiak
Copy link
Contributor

@padilo what's stopping you from using 2.4.x?

@padilo
Copy link
Author

padilo commented May 3, 2022

We are still using Spring Cloud Ilford (2020.0.5), which is compatible with Spring Boot 2.4.x-2.5.x, so we need to use Spring Cloud AWS 2.3.x

@maciejwalkowiak maciejwalkowiak merged commit 7699297 into awspring:2.3.x May 3, 2022
@padilo padilo deleted the relax-validation branch May 3, 2022 08:35
@padilo
Copy link
Author

padilo commented May 3, 2022

Thank you, eager to get the release 2.3.5 :)

@maciejwalkowiak
Copy link
Contributor

@padilo 2.3.5 released, should appear in Maven soon

https://github.com/awspring/spring-cloud-aws/releases/tag/v2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants