Consolidate all caller of io_ops_commit() to call td_io_commit() - #2139
Merged
Merged
Conversation
Calling io_ops->commit() will not update io_u_in_flight and io_u_queued accordingly. If iio_u_queued is not reset properly the fio may need to make unnecessary stop to drain the queue. Which may degrade the throughput. Signed-off-by: Dennis Chang <cherhungc@google.com>
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling io_ops->commit() will not update io_u_in_flight and io_u_queued accordingly. If iio_u_queued is not reset properly the fio may need to make unnecessary stop to drain the queue. Which may degrade the throughput.
Fix issue: #2052
Please confirm that your commit message(s) follow these guidelines:
aren't something like a URL at 72-74 chars.
Reminders:
cconv.c and bump FIO_SERVER_VER in server.h
FIO_IOOPS_VERSION in ioengines.h.