Skip to content

Consolidate all caller of io_ops_commit() to call td_io_commit() - #2139

Merged
axboe merged 1 commit into
axboe:masterfrom
dennischerchang:consolidate_commit_call_path
Sep 2, 2026
Merged

Consolidate all caller of io_ops_commit() to call td_io_commit()#2139
axboe merged 1 commit into
axboe:masterfrom
dennischerchang:consolidate_commit_call_path

Conversation

@dennischerchang

@dennischerchang dennischerchang commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Calling io_ops->commit() will not update io_u_in_flight and io_u_queued accordingly. If iio_u_queued is not reset properly the fio may need to make unnecessary stop to drain the queue. Which may degrade the throughput.

Fix issue: #2052

Please confirm that your commit message(s) follow these guidelines:

  1. First line is a commit title, a descriptive one-liner for the change
  2. Empty second line
  3. Commit message body that explains why the change is useful. Break lines that
    aren't something like a URL at 72-74 chars.
  4. Empty line
  5. Signed-off-by: Real Name real@email.com

Reminders:

  1. If you modify struct thread_options, also make corresponding changes in
    cconv.c and bump FIO_SERVER_VER in server.h
  2. If you change the ioengine interface (hooks, flags, etc), remember to bump
    FIO_IOOPS_VERSION in ioengines.h.

Calling io_ops->commit() will not update io_u_in_flight and io_u_queued
accordingly. If iio_u_queued is not reset properly the fio may need to
make unnecessary stop to drain the queue. Which may degrade the throughput.

Signed-off-by: Dennis Chang <cherhungc@google.com>
@axboe
axboe merged commit 975ea18 into axboe:master Sep 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants