[GIT PULL] man page and build warning fixes#689
Merged
Conversation
This function doesn't return anything, the return type should be void. Fixes: f01ed8b ("Add man pages for shared provided buffer rings") Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
This function doesn't return anything, the return type should be void. Fixes: f01ed8b ("Add man pages for shared provided buffer rings") Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Building with clang v13.0.1 yields the following warning:
./helpers.h:29:42: warning: declaration of 'struct sockaddr_in' \
will not be visible outside of this function [-Wvisibility]
int t_bind_ephemeral_port(int fd, struct sockaddr_in *addr);
^
This is because at that point struct sockaddr_in has not been
declared yet. Fix this by including <arpa/inet> in helpers.h.
Fixes: 0a2d0af ("test/helpers: Add `t_bind_ephemeral_port()` function")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jens,
Fix the wrong return type in io_uring_buf_ring_advance
and io_uring_buf_ring_cq_advance man page (Alviro)
Clean up a build warning when compiling with clang v13.0.1 (me)
Please pull!