Improve linux editbox - #3206
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
/clang-format |
There was a problem hiding this comment.
Code Review
This pull request refactors the Linux EditBox implementation to use an asynchronous GTK3 dialog with event polling instead of a blocking modal dialog. However, the changes completely remove the updatePosition logic, which breaks compilation and functionality on iOS and macOS platforms. Additionally, several issues were identified in the new Linux implementation: the EditBox can get stuck in editing mode when the dialog loses focus, a potential crash or memory leak exists if the EditBox is destroyed while the dialog is open, Wayland support is broken by restricting polling to X11, and using std::this_thread::sleep_for in the event loop can cause main thread stuttering.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/clang-format |
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR