Skip to content

Improve linux editbox - #3206

Merged
halx99 merged 4 commits into
devfrom
improve-linux-editbox
Jun 19, 2026
Merged

Improve linux editbox#3206
halx99 merged 4 commits into
devfrom
improve-linux-editbox

Conversation

@halx99

@halx99 halx99 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Jun 19, 2026
@halx99 halx99 added the enhancement New feature or request label Jun 19, 2026
@codacy-production

codacy-production Bot commented Jun 19, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 15 complexity · 2 duplication

Metric Results
Complexity 15
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@halx99

halx99 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

/clang-format

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Linux EditBox implementation to use an asynchronous GTK3 dialog with event polling instead of a blocking modal dialog. However, the changes completely remove the updatePosition logic, which breaks compilation and functionality on iOS and macOS platforms. Additionally, several issues were identified in the new Linux implementation: the EditBox can get stuck in editing mode when the dialog loses focus, a potential crash or memory leak exists if the EditBox is destroyed while the dialog is open, Wayland support is broken by restricting polling to X11, and using std::this_thread::sleep_for in the event loop can cause main thread stuttering.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread axmol/ui/EditBox/EditBox.cpp
Comment thread axmol/ui/EditBox/EditBox.cpp
Comment thread axmol/ui/EditBox/EditBox.cpp
Comment thread axmol/ui/EditBox/EditBox.h
Comment thread axmol/ui/EditBox/EditBoxImpl.h
Comment thread axmol/ui/EditBox/EditBoxImpl-linux.cpp
Comment thread axmol/ui/EditBox/EditBoxImpl-linux.h Outdated
Comment thread axmol/ui/EditBox/EditBoxImpl-linux.cpp
@halx99

halx99 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

/clang-format

@halx99
halx99 merged commit 8389185 into dev Jun 19, 2026
21 checks passed
@halx99
halx99 deleted the improve-linux-editbox branch June 19, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants