Conversation
azat
changed the title
Every provider ended with the same drop_main_view/set_main_view/ focus_name triple; fold it into a single present_view(focus, view) so the main-view slot has one owner (prepares for pane support). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
present_view() replaces the focused pane via add-new-then-remove-old: the lone pane cannot be removed from the Mux tree. The replacement view is constructed before the old one drops, so ViewAction gains an owner and Drop retains foreign actions instead of clear(). Requires azat-rust/cursive-multiplex branch chdig (Mux::focus_view). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
split_pane() adds a focusable stub pane and opens the views menu; the selected view replaces the stub since present_view targets the focused pane. q quits only from the last pane. Focus/resize/zoom are Mux-native (Alt+Arrows, Ctrl+Arrows, Ctrl+x). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Action menus listed every live view's actions and duplicate texts resolved to an arbitrary pane. Filter by ViewAction.owner in the focused pane subtree; collapse to one pane on host-filter change (other panes embed the old filter in their queries). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Covers query/table/replica/logger logs; --logs-in-dialog (or the F3 settings checkbox) restores the dialog. TextLog worker channel key includes the view name (a shared capacity-1 channel drops updates of concurrent log views). LogViewBase gets take_focus: without it the pane layout and Mux click-to-focus refuse focus. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…lose) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
remove_id() kept the replaced view and its BackgroundRunner alive (every ever-opened view kept querying), could focus a view-less split node (dead-ending all key/mouse input), and after a view replacement left the root leaf with a stale ancestor chain - the next added pane (split, logs) landed outside the tree: invisible, but querying. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Separators bordering the focused pane draw in the highlight color (cursive-multiplex); view titles render bright cyan in the focused pane and dim cyan elsewhere. A separator shared by two panes cannot disambiguate them, the title can. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Shortcuts
Alt+Arrows - navigationAlt+-/=s split pane right/belowCtrl+Arrows - resizeCtrl-x- zoomLimitations
Fixes: #164