Faster integration tests - #287
Merged
Merged
Conversation
Relative "now" in SQL time bounds was rendered as now(), which has second precision: rows failing event_time_microseconds <= end_time_ within the current second only appeared on the next background refresh (--delay_interval, 30s by default) - the cause of the bimodal 30s stalls in the TUI tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Refresh sent per received frame kept the TUI loop out of its 30ms idle wait, spinning it (and wait_for) in lockstep at full speed - a core burned for the whole suite. The loop emits a frame every iteration anyway, so just consume them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
And sometimes we even had tests that took > 60 seconds
Now: