Bind lm-eval sample count provenance#116
Conversation
|
Read the diff in full, and it lands exactly on the narrow gap #115 names: same effective What I checked
Two observations, neither blockingThe fields use lm-eval's own vocabulary (
Note I reviewed this at diff level against main and rely on the CI matrix for the execution side this time, so my merge waits for the full set of required checks, mutation included. One more thing your change surfaces: with The optional third bullet of #115, binding the aggregation identity for the matched metric, is intentionally not in here. The issue marked it optional, so closing #115 with this is fine by me. If you feel like it, that bullet can become its own small issue. On our side this joins the changelog and versioning step we already owe from #112: new signed provenance fields will not land silently, they get a changelog entry and a version decision in one step for both adapters. Same as last time: I will merge after you mark it ready and the required checks are green, with your commit and credit preserved. Thanks for coming back for the second half of the parity. Konrad |
|
Merged with your commit as-is, thank you. Sample-count provenance now travels inside the signed receipt, and receipts with equal effective n but different dropout are distinguishable, exactly the #115 gap. The changelog entry for both adapter provenance additions follows in the next version step. |
What changed
effective_samples,original_samples, and the non-negativeskipped_samplesdelta in signed provenancenand compatibility fallbackWhy
The lm-eval adapter already uses the effective sample count for the claim population, but it did not preserve how many source samples were dropped. Receipts with the same effective count and different original counts were therefore indistinguishable on that axis.
This is the narrow sample-accounting parity follow-up described in #115. It does not add aggregation identity, infer reliability, or add a runtime dependency.
Validation
PYTHONPATH=src:. python -m pytest -qruff check .mypy srcgit diff --checkCloses #115.