Add styling for Code Blocks - #1532
Conversation
|
Deploy preview for babel ready! Built with commit 3763699 |
|
@SavePointSam Hi. Do you think we could use this (or some variation) as an upstream patch to Docusaurus? I certainly do not mind pushing out a bug fix release of Docusaurus if that helps things along here. |
|
Hey @JoelMarcey, this PR is just to add styling for the new Babel site. I'm not sure what you'd want to pull out of here and put into Docusaurus. What were you thinking to add? It's mostly just CSS. Personally, I wouldn't want to add the CSS I wrote here to Docusaurus. It was just making the most of what I had available to me. I'd rather post a PR to Docusaurus in order to add the changes I've made here in more maintainable and proper way. Would you be interested in me adding the code block headers? I can write something up and have a PR rather quickly. |
|
Fine with just landing this for now since it's just 2 standalone css files and we can remove later if we find another solution or it's fixed in docusaurus later. |
|
Thanks @SavePointSam, awesome |
|
@SavePointSam Yeah, it is possible I misunderstood the overall intent of this PR yesterday -- I saw "glitch in Docusaurus" and thought there was maybe something that could have been upstreamed to fix to better support "Tomorrow". |
This adds the styling of code block on the old website back onto the new one. Due to a glitch on Docusaurus, the Tomorrow theme needed to be added manually for Highlight.js