Conversation
I add a space to reveal this function for commenting, otherwise i cannot add comments for this function
This is to fix a conflict that is caused by my modification in a previous PR
|
Hi @dominikbach apologies for uploading two commits to this PR.
|
| % missing epochs | ||
| if isfield(job.session(iSession).missing,'epochfile') | ||
| if isfield(job.session(iSession).missing,'epochfile') | ||
| model.missing{1,iSession} = job.session(iSession).missing.epochs.epochfile{1}; |
There was a problem hiding this comment.
I think this two lines look weird. If the intention is to check if there is a field epochfile under job.session(1).missing, the next line of code may want to say ... = job.session(1).missing.epochfile, yet it used job.session(1).missing.epochs.epochfile. This function reported an error in PR 729, because the detected epochfile was assigned to .missing instead of .missing.epochs.
There was a problem hiding this comment.
At the line 331, the function uses pspm_cfg_python. This function has been renamed to pspm_cfg_selector_python, so the name of this function needs to be changed here too.
| function out = pspm_cfg_python(varargin) | ||
| function out = pspm_cfg_selector_python(varargin) | ||
| % ● Description | ||
| % pspm_cfg_python is a function that provides UI controls for |
There was a problem hiding this comment.
The help text needs to be updated too, maybe add some examples
|
I approved this PR as the test in GUI at my side seems to operate well. I will continue testing in the PR 721 later. |

Stylises the Matlabbatch more uniformly.
Changes proposed in this pull request: