Conversation
dominikbach
added
the
Completed & Waiting for Review
| hprf_rew.name = 'HPRF_REW'; | ||
| hprf_rew.tag = 'hprf_rew'; | ||
| hprf_rew.val = {1}; | ||
| hprf_rew.help = {'HPRF_REW without derivatives.'}; |
There was a problem hiding this comment.
I suggest to include the full name of "HPRF_REW" in the help text for people like me who do not have knowledge of the field but may have the intention to use it as a black box for own purposes.
There was a problem hiding this comment.
good idea - fixed.
| vars.glmhelp = ''; | ||
|
|
||
| % load default settings | ||
| glm_hp_rew = pspm_cfg_glm(vars); |
There was a problem hiding this comment.
There is a "Nuisance File" option, and it does not have to be specified, because on the current design. I am unsure if this is intentional or not. If it is an optional file, I would suggest to add "optional" in the help text. If it is mandatory, I suggest to report an error if it is not suggested. Currently it is not mandatory and can be left black for running the module.
There was a problem hiding this comment.
a generic stylistic issue for GLM, will be dealt with in future PR.
| glm_hp_rew.tag = 'glm_hp_rew'; | ||
|
|
||
| % set callback function | ||
| glm_hp_rew.prog = @pspm_cfg_run_glm_hp_rew; |
|
Minor comments regarding the text and UI. Critical errors will be put in #728 since they are more related to CFG functions than this new model. |
teddphil
added
Approved
teddphil
removed
the
Approved
2 participants
Fixes #579 .
Changes proposed in this pull request:
pspm_bf_hprf_rewpspm_init