Merged
Conversation
dominikbach
added
Completed & Waiting for Review
Merged
teddphil
reviewed
Aug 12, 2024
| pspm_text([pspm_root, filesep]); | ||
| load(fullfile(pspm_root,'pspm_text.mat')) | ||
|
|
||
| % 2.5 Add required paths --- |
teddphil
reviewed
Aug 12, 2024
| numel(g_endmarker) ~= 1 || ... | ||
| startmarker < 1 || ... | ||
| g_endmarker < startmarker | ||
| warning('ID:invalid_input', 'No valid reference markers.\n'); return |
There was a problem hiding this comment.
Think at line 237, the ndata can be changed to data_struct if preferred...
teddphil
added
Approved
teddphil
removed
Improvement
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #657 .
Should be reviewed AFTER #735 is merged.
Changes proposed in this pull request:
pspm_textinto the respectivepspm_get_...functionspspm_textpspm_textintopspm_help_textfor future use with help itemspspm_help_textinto a function so that saving of the filepspm_text.matis no longer necessary