Skip to content

Bugfixes#759

Merged
teddphil merged 21 commits intodevelopfrom
bugfixes
Aug 23, 2024
Merged

Bugfixes#759
teddphil merged 21 commits intodevelopfrom
bugfixes

Conversation

@dominikbach
Copy link
Copy Markdown
Contributor

@dominikbach dominikbach commented Aug 8, 2024 •
edited
Loading

Fixes #103 .

Should be reviewed after merging #756 .
Changes proposed in this pull request:

  • several bug fixes and improvements detected during beta testing

@dominikbach dominikbach added the In Progress Currently being worked on label Aug 8, 2024
@dominikbach dominikbach requested a review from teddphil August 9, 2024 15:26
@dominikbach dominikbach self-assigned this Aug 9, 2024
@dominikbach dominikbach added Bug Something isn't working Completed & Waiting for Review Completed and waiting for review Improvement A minor improvement to the project and removed In Progress Currently being worked on labels Aug 9, 2024
@dominikbach dominikbach added this to the v7.0 milestone Aug 9, 2024
@teddphil teddphil added Under Review and removed Completed & Waiting for Review Completed and waiting for review labels Aug 12, 2024
teddphil
teddphil reviewed Aug 21, 2024
View reviewed changes
Comment thread src/pspm_cfg/pspm_cfg_pp_pupil.m
teddphil
teddphil suggested changes Aug 21, 2024
View reviewed changes
Comment thread src/pspm_cfg/pspm_cfg_help_format.m
Comment thread src/pspm_find_valid_fixations.m
Comment thread src/pspm_split_sessions.m Outdated
Comment thread src/pspm_split_sessions.m
Comment thread src/pspm_cfg/pspm_cfg_split_sessions.m
Comment thread src/pspm_cfg/pspm_cfg_run_dcm.m
Comment thread src/pspm_cfg/pspm_cfg_run_sf.m
@teddphil teddphil added Changes Requested Authors are requested to make changes and removed Under Review labels Aug 21, 2024
@dominikbach dominikbach added Completed & Waiting for Review Completed and waiting for review and removed Changes Requested Authors are requested to make changes labels Aug 23, 2024
@dominikbach
Copy link
Copy Markdown
Contributor Author

dominikbach commented Aug 23, 2024

I fixed another bug which lead to copying missing epochs from one session to the next in DCM.

@teddphil teddphil merged commit 353bde6 into develop Aug 23, 2024
@teddphil teddphil deleted the bugfixes branch August 23, 2024 09:17
@teddphil teddphil removed Bug Something isn't working Completed & Waiting for Review Completed and waiting for review Improvement A minor improvement to the project labels Aug 25, 2024
@teddphil teddphil mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teddphil teddphil teddphil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dominikbach dominikbach

Labels

None yet

Projects

None yet

Milestone

v7.0

Development

Successfully merging this pull request may close these issues.

Move privately used functions from backroom to a new private folder

2 participants

@dominikbach @teddphil