Skip to content

Reduce cognitive complexity in five benchmark test classes #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce cognitive complexity in five benchmark test classes #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01197.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)

String cookieName = "rememberMe" + testCaseNumber;

boolean foundUser = false;
javax.servlet.http.Cookie[] cookies = request.getCookies();
if (cookies != null) {
for (int i = 0; !foundUser && i < cookies.length; i++) {
javax.servlet.http.Cookie cookie = cookies[i];
if (cookieName.equals(cookie.getName())) {
if (cookie.getValue()
.equals(request.getSession().getAttribute(cookieName))) {
foundUser = true;
}
}
}
}
boolean foundUser = isUserFound(request, cookieName);

if (foundUser) {
response.getWriter().println("Welcome back: " + user + "<br/>");
Expand Down Expand Up @@ -116,6 +104,21 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
} // end doPost

private boolean isUserFound(HttpServletRequest request, String cookieName) {
javax.servlet.http.Cookie[] cookies = request.getCookies();
if (cookies != null) {
for (int i = 0; i < cookies.length; i++) {
javax.servlet.http.Cookie cookie = cookies[i];
if (cookieName.equals(cookie.getName())
&& cookie.getValue()
.equals(request.getSession().getAttribute(cookieName))) {
return true;
}
}
}
return false;
}

private class Test {

public String doSomething(HttpServletRequest request, String param)
Expand Down
33 changes: 17 additions & 16 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01399.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text/html;charset=UTF-8");

String param = "";
boolean flag = true;
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements() && flag) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length && flag; i++) {
String value = values[i];
if (value.equals("BenchmarkTest01399")) {
param = name;
flag = false;
}
}
}
}
String param = extractParam(request);

String bar = new Test().doSomething(request, param);

Expand Down Expand Up @@ -120,6 +105,22 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
"Crypto Test javax.crypto.Cipher.getInstance(java.lang.String,java.lang.String) executed");
} // end doPost

private static String extractParam(HttpServletRequest request) {
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements()) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length; i++) {
if (values[i].equals("BenchmarkTest01399")) {
return name;
}
}
}
}
return "";
}

private class Test {

public String doSomething(HttpServletRequest request, String param)
Expand Down
37 changes: 21 additions & 16 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02295.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text/html;charset=UTF-8");

String param = "";
boolean flag = true;
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements() && flag) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length && flag; i++) {
String value = values[i];
if (value.equals("BenchmarkTest02295")) {
param = name;
flag = false;
}
}
}
}
String param = extractParam(request);

String bar = doSomething(request, param);

Expand Down Expand Up @@ -130,6 +115,26 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
} // end doPost

private static String extractParam(HttpServletRequest request) {
String param = "";
boolean flag = true;
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements() && flag) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length && flag; i++) {
String value = values[i];
if (value.equals("BenchmarkTest02295")) {
param = name;
flag = false;
}
}
}
}
return param;
}

private static String doSomething(HttpServletRequest request, String param)
throws ServletException, IOException {

Expand Down
37 changes: 21 additions & 16 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02360.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text/html;charset=UTF-8");

String param = "";
boolean flag = true;
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements() && flag) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length && flag; i++) {
String value = values[i];
if (value.equals("BenchmarkTest02360")) {
param = name;
flag = false;
}
}
}
}
String param = extractParam(request);

String bar = doSomething(request, param);

Expand All @@ -79,6 +64,26 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
} // end doPost

private static String extractParam(HttpServletRequest request) {
String param = "";
boolean flag = true;
java.util.Enumeration<String> names = request.getParameterNames();
while (names.hasMoreElements() && flag) {
String name = (String) names.nextElement();
String[] values = request.getParameterValues(name);
if (values != null) {
for (int i = 0; i < values.length && flag; i++) {
String value = values[i];
if (value.equals("BenchmarkTest02360")) {
param = name;
flag = false;
}
}
}
}
return param;
}

private static String doSomething(HttpServletRequest request, String param)
throws ServletException, IOException {

Expand Down
29 changes: 16 additions & 13 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02614.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)

String cookieName = "rememberMe" + testCaseNumber;

boolean foundUser = false;
javax.servlet.http.Cookie[] cookies = request.getCookies();
if (cookies != null) {
for (int i = 0; !foundUser && i < cookies.length; i++) {
javax.servlet.http.Cookie cookie = cookies[i];
if (cookieName.equals(cookie.getName())) {
if (cookie.getValue()
.equals(request.getSession().getAttribute(cookieName))) {
foundUser = true;
}
}
}
}
boolean foundUser = findUserCookie(request, cookieName);

if (foundUser) {
response.getWriter().println("Welcome back: " + user + "<br/>");
Expand Down Expand Up @@ -132,6 +120,21 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
} // end doPost

private static boolean findUserCookie(HttpServletRequest request, String cookieName) {
javax.servlet.http.Cookie[] cookies = request.getCookies();
if (cookies != null) {
for (int i = 0; i < cookies.length; i++) {
javax.servlet.http.Cookie cookie = cookies[i];
if (cookieName.equals(cookie.getName())
&& cookie.getValue()
.equals(request.getSession().getAttribute(cookieName))) {
return true;
}
}
}
return false;
}

void getNextNumber(java.util.Random generator, byte[] barray) {
generator.nextBytes(barray);
}
Expand Down