Skip to content

Reuse SecureRandom instances across benchmark test classes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reuse SecureRandom instances across benchmark test classes #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00257.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
public class BenchmarkTest00257 extends HttpServlet {

private static final long serialVersionUID = 1L;
private static final java.security.SecureRandom random = new java.security.SecureRandom();

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
Expand Down Expand Up @@ -56,11 +57,10 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// Code based on example from:
// http://examples.javacodegeeks.com/core-java/crypto/encrypt-decrypt-file-stream-with-des/
// 8-byte initialization vector
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3033
// };
java.security.SecureRandom random = new java.security.SecureRandom();
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3033
// };
byte[] iv = random.generateSeed(8); // DES requires 8 byte keys

try {
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00776.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public class BenchmarkTest00776 extends HttpServlet {

private static final long serialVersionUID = 1L;

private java.security.SecureRandom random = new java.security.SecureRandom();

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
Expand Down Expand Up @@ -81,13 +83,12 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// AES/GCM example from:
// https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/
// 16-byte initialization vector
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
java.security.SecureRandom random = new java.security.SecureRandom();
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
byte[] iv = random.generateSeed(16);

try {
Expand Down
14 changes: 7 additions & 7 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01976.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
public class BenchmarkTest01976 extends HttpServlet {

private static final long serialVersionUID = 1L;
private static final java.security.SecureRandom random = new java.security.SecureRandom();

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
Expand Down Expand Up @@ -65,13 +66,12 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// AES/GCM example from:
// https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/
// 16-byte initialization vector
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
java.security.SecureRandom random = new java.security.SecureRandom();
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
byte[] iv = random.generateSeed(16);

try {
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02017.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
public class BenchmarkTest02017 extends HttpServlet {

private static final long serialVersionUID = 1L;
private static final java.security.SecureRandom random = new java.security.SecureRandom();

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
Expand Down Expand Up @@ -55,11 +56,10 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// Code based on example from:
// http://examples.javacodegeeks.com/core-java/crypto/encrypt-decrypt-file-stream-with-des/
// 8-byte initialization vector
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3033
// };
java.security.SecureRandom random = new java.security.SecureRandom();
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3033
// };
byte[] iv = random.generateSeed(8); // DES requires 8 byte keys

try {
Expand Down
14 changes: 7 additions & 7 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02191.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
public class BenchmarkTest02191 extends HttpServlet {

private static final long serialVersionUID = 1L;
private java.security.SecureRandom random = new java.security.SecureRandom();

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
Expand All @@ -54,13 +55,12 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// AES/GCM example from:
// https://javainterviewpoint.com/java-aes-256-gcm-encryption-and-decryption/
// 16-byte initialization vector
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
java.security.SecureRandom random = new java.security.SecureRandom();
// byte[] iv = {
// (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2,
// (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3,
// (byte)0xF3, (byte)0x3C, (byte)0x23, (byte)0xB9,
// (byte)0x9E, (byte)0xC5, (byte)0x77, (byte)0x0B033
// };
byte[] iv = random.generateSeed(16);

try {
Expand Down