Skip to content

Clean up retry logging and remove superfluous branch - #223

Merged
bachya merged 1 commit into
devfrom
cleanuo
Mar 1, 2021
Merged

Clean up retry logging and remove superfluous branch#223
bachya merged 1 commit into
devfrom
cleanuo

Conversation

@bachya

@bachya bachya commented Mar 1, 2021

Copy link
Copy Markdown
Owner

Describe what the PR does:

Following up on #222, this PR:

  1. Fixes some incorrect logging during request retry
  2. Removes a superfluous branch that couldn't be reached

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md and docs/ with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the maintenance Generic library tasks label Mar 1, 2021
@bachya bachya self-assigned this Mar 1, 2021
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 285bec7 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov

codecov Bot commented Mar 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #223 (285bec7) into dev (27be2e9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          858       858           
=========================================
  Hits           858       858           
Impacted Files Coverage Δ
simplipy/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27be2e9...285bec7. Read the comment docs.

@bachya
bachya merged commit 2a2ba7c into dev Mar 1, 2021
@bachya
bachya deleted the cleanuo branch March 1, 2021 19:47
@bachya bachya mentioned this pull request Mar 2, 2021
4 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance Generic library tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant