Skip to content

coder_upgrade_upgrade_regex_info_alter() assumes .info file belongs to module, but can also be a theme #63

@klonos

Description

@klonos

Not sure exactly how to best do it, but at some point I think that we should implement something like this:

Change this:

function coder_upgrade_upgrade_regex_info_alter(&$file) {
...
  $to[] = "backdrop = 1.x\ntype = module";
...
}

...to something like this:

function coder_upgrade_upgrade_regex_info_alter(&$file, $type = 'module') {
...
  $to[] = "backdrop = 1.x\ntype = $type";
...
}

Then we need to figure out how to best detect whether we are converting a module of theme .info file, and where/how to pass $type accordingly.

Here's some info that might help (see: https://www.drupal.org/docs/7/theming/writing-theme-info-files#s-theme-name-requirements):

Theme .info files in Drupal 7 are required to have a name = and a core = entry (same as modules), but they may also contain entries for:

  • engine: (optional, defaults to phptemplate)
  • regions[]: (optional, with defaults provided by D7 core)
  • stylesheets[]: (required in D7) an array of all .css files you want the theme to use.
  • scripts[]: (required in D7) an array of all .js files you want the theme to use.
  • features[]: (optional) for page elements that can be toggled on/off, such as site logo/name/slogan/favicon/main_menu/secondary_menu etc.
  • settings[]: (optional) if these entries exist, there should also be a theme-settings.php file in the root folder of the theme.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions