Skip to content

Issue #78: Fix error in conversion.inc when $status == 0 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Issue #78: Fix error in conversion.inc when $status == 0 #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions includes/conversion.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,14 @@ function coder_upgrade_directory_list() {
function coder_upgrade_module_list($core = NULL, $status = -1) {
$test = is_null($core) ? config_get('coder_upgrade.settings', 'coder_upgrade_upgrade_core') : $core;
$like = $test ? 'LIKE' : 'NOT LIKE';
$where = $status == -1 ? '' : 'AND status = :status';
if ($status == -1) {
$where = '';
$args = array();
}
else {
$where = 'AND status = :status';
$args = array(':status' => $status);
}

// Faster to query DB than to rescan files using _system_get_module_data().
$sql = "SELECT name, filename, type, status, info,
Expand All @@ -570,7 +577,7 @@ function coder_upgrade_module_list($core = NULL, $status = -1) {
$where
ORDER BY directory, name";
$default_value = 0;
$results = db_query($sql, array(':status' => $status));
$results = db_query($sql, $args);
$rows = array();
foreach ($results as $module) {
$info = unserialize($module->info);
Expand Down