[UX] Views: Pager options: the "Items per page" label does not make sense for "Display a specified number of items"

[klonos]

I just said "specified number of items" (read: "no pager"!) ...what is this "items per page" thing?

Should say "Total items" or "Maximum number of items".

---

PR by @klonos: backdrop/backdrop#1904

[quicksketch]

This looks like it would be pretty trivial to fix. Considering the pager type (None) and the pager options are on two separate forms. No JS required to fix this problem.

[Graham-72]

I see that it is a one year anniversary today for this issue! I think the questions need to be restructured in order to make their purpose clear. Perhaps question 1 should be whether the view should limit the number of items displayed, if so what is the limit. Then question 2 should be whether a pager should be used, if so should it be a full or a mini pager.
Alternatively the subheading 'PAGER' could be replaced with something more explanatory like 'ITEMS PER PAGE' and 'Use pager' could be 'Options'.

[klonos]

I've filed a PR that fixes this issue plus some other UX inconsistencies. For example, there is no reason to be displaying for singular "1 item, skip x", because if you skip any number of items while you have configured only a single one to be displayed, then there will be no items to be rendered in the first place. This has to do with the fact that there is no validation in the pager settings forms, but I think that it will be best to tackle that in another issue (already filed #1433 for that).

I will shortly post some before/after screenshots to make it easier for those that will review the PR...

[klonos]

"Display a specified number of items" option, no offset:

• before:
  

• after:
  

"Display a specified number of items" option, with offset set:

• before:
  

• after: