feat(review): [optional] Add opt-out for platform review attribution#1026
Closed
leoreisdias wants to merge 1 commit into
Closed
feat(review): [optional] Add opt-out for platform review attribution#1026leoreisdias wants to merge 1 commit into
leoreisdias wants to merge 1 commit into
Conversation
Owner
|
@leoreisdias thank you for raising this. We decided on a simpler product direction: no attribution and no setting. #1033 supersedes this PR with the minimal implementation, and GitHub credits you as a co-author on the commit. Closing this one in favor of #1033. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Plannotator currently adds
Review from Plannotatorto GitHub and GitLab review bodies whenever a review is submitted from the code-review UI. That attribution is useful as a consistent product signal, but some users may prefer PR/MR comments to read as plain review text without the tool signature.This PR keeps the current behavior as the default and adds a small review-mode preference for opting out.
What Changed
platformReviewAttributionconfig setting, defaulting totrue.Review from Plannotatoronly when that setting is enabled.~/.plannotator/config.jsonacross runtimes.Screenshot
Review Focus
The main behavior to check is that the default remains unchanged: existing users should still get
Review from Plannotatorunless they explicitly disable the new setting.The config plumbing is intentionally broad because the shared settings UI can be hosted by plan, annotate, review, and Pi runtime servers. Review the
/api/confighandlers if you want to make sure the setting persists consistently across those surfaces.Test Plan
bunx --package typescript tscfor core, shared, ai, server, ui, strict consumer, and Pi projects.bun run build:review && bun run build:hookso the local CLI served the updated review UI.plannotator reviewon this worktree; review completed with no changes requested../bin/plannotator.js review https://github.com/Lexamica/lexamica-refer/pull/1167to exercise the local CLI PR review flow; it opened the PR review UI and successfully approved the PR on GitHub.