chore: fold in pre-release QA findings (print overlays, doc alignment) - #1245
Merged
Conversation
From the 25-item QA sweep over the v0.26.4..main range (all items passed; these were the three real minors worth folding into the release): - The raw-HTML iframe's injected CSS had no print rules, so pin badges (and, in a narrow window, the pinpoint outline box) printed into hard copies of annotated HTML pages. The overlay elements now carry an explicit @media print hide inside the iframe document, where the outer print.css cannot reach. Inline annotation marks stay printable on purpose, matching markdown documents. - AGENTS.md/CLAUDE.md now state that PLANNOTATOR_ANNOTATE_HISTORY also gates the durable submitted-feedback records from #1237, and the Annotation interface listing includes the htmlAnchor field from #1243. - apps/codex/README.md aligns with the #1241 top-level wording (Windows Codex hooks are experimental with printed manual steps, not disabled). - Marketing docs: annotate page documents the pinpoint-first default and minimal-first chrome for raw-HTML sessions; installation page notes the old-git plain-clone fallback from #1239.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: The pre-release 25-item QA sweep over v0.26.4..main confirmed zero serious regressions. These are the three real minor findings worth shipping with v0.26.5: a print-CSS gap that baked pin badges into printed HTML pages, and doc passages the range made stale.
AI-assisted (QA workflow findings, fixes, and this PR).
@media printrule; the outerprint.csscannot reach inside the iframe document. Reproduced by the QA agent with headless-Chrome print-to-PDF: a numbered badge rendered in the printed output. Now hidden in print; inline annotation marks intentionally remain printable, matching markdown.PLANNOTATOR_ANNOTATE_HISTORYalso gates the fix(annotate): persist submitted feedback before deleting the draft (#678) #1237 durable submitted-feedback records (and the Annotation type listing gainshtmlAnchor); apps/codex/README.md matches the Codex Stop-hook plan review on native Windows #1241 wording; marketing annotate docs describe the pinpoint-first / minimal-chrome HTML sessions; marketing install docs mention the fix(install): fall back to a plain shallow clone when git lacks --sparse #1239 old-git fallback.Verified: html-viewer DOM suite 32/32, packages/ui typecheck clean, marketing site builds (40 pages).