feat(jaeger): add new frontend system support - #9783
Conversation
Changed Packages
|
There was a problem hiding this comment.
Pull request overview
Adds New Frontend System (alpha) support for the Jaeger workspace plugin, enabling installation via the @backstage-community/plugin-jaeger/alpha export and registering the plugin’s API + entity content extension for feature discovery / configuration.
Changes:
- Introduces
src/alpha/*entrypoint withcreateFrontendPlugin, API blueprint, and entity content blueprint. - Updates package exports and dependencies to include
@backstage/frontend-plugin-apiand@backstage/core-compat-api. - Adds documentation and an API extractor alpha report, plus a changeset for the new capability.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspaces/jaeger/yarn.lock | Locks newly added Backstage frontend-system dependencies. |
| workspaces/jaeger/plugins/jaeger/src/alpha/plugin.ts | Defines the alpha frontend-system plugin and binds legacy route refs. |
| workspaces/jaeger/plugins/jaeger/src/alpha/plugin.test.ts | Adds a basic unit test for the alpha plugin export. |
| workspaces/jaeger/plugins/jaeger/src/alpha/index.ts | Exposes the alpha plugin as the default export for /alpha. |
| workspaces/jaeger/plugins/jaeger/src/alpha/entityContents.tsx | Adds the entity content (tab) extension using compat wrapper + route ref conversion. |
| workspaces/jaeger/plugins/jaeger/src/alpha/apis.ts | Adds the API extension wiring jaegerApiRef to JaegerClient. |
| workspaces/jaeger/plugins/jaeger/report-alpha.api.md | Adds generated alpha API report reflecting the new exports/extensions. |
| workspaces/jaeger/plugins/jaeger/README.md | Documents how to install/configure the plugin in the new frontend system. |
| workspaces/jaeger/plugins/jaeger/package.json | Adds ./alpha export + typesVersions and required dependencies. |
| workspaces/jaeger/.changeset/jaeger-new-frontend-system.md | Declares a minor release for the new alpha frontend-system support. |
Closes backstage#7538 Signed-off-by: RonitGandhi <ronitgandhi.16@gmail.com>
…s map The exports map supersedes these fields; yarn fix --check flagged the package as out of sync. Signed-off-by: RonitGandhi <ronitgandhi.16@gmail.com>
- Drop `@backstage/core-compat-api` entirely. Per the upstream plugin-new-frontend-system-support skill, `convertLegacyRouteRef(s)` and `compatWrapper` are no longer required for plugin migration, and this workspace is on Backstage 1.52. Route refs from `@backstage/core-plugin-api` are now passed directly to the plugin and to `EntityContentBlueprint`. - Expose the route under `root` instead of `entityContent`, matching the route contract already published by the legacy plugin in `src/plugin.ts`. - Strengthen the alpha test: it now imports the default export through the public `./alpha` entry point, asserts the API and entity content extensions are registered, pins the `root` route mapping, renders the Traces content against a mocked Jaeger API, and covers the annotation filter. - Nest "Extensions config" as a subsection of "New Frontend System" in the README. - Regenerate report-alpha.api.md and knip-report.md. Signed-off-by: RonitGandhi <ronitgandhi.16@gmail.com>
a88159d to
f2d5f24
Compare
|
Thanks for the reviews! Rebased onto latest @04kash — ran the changes against the Walking the rest of the skill's checklist: this plugin contributes an entity content tab rather than a top-level page, so the Copilot comments:
|
Closes #7538
Hey, I just made a Pull Request!
Adds new frontend system (alpha) support to the Jaeger plugin: registers the Jaeger API and the Traces entity content extension via a new
./alphaexport. Legacy exports are unchanged. Closes #7538.✔️ Checklist
Signed-off-byline in the message. (more info)