Skip to content
This repository was archived by the owner on Nov 19, 2021. It is now read-only.
This repository was archived by the owner on Nov 19, 2021. It is now read-only.

TechDocs serve not killing process #176

@ottosichert

Description

@ottosichert

While improving the tests in #169 (comment) occasionally the serve process on port 8000 is not terminated, causing subsequent tests to fail, or trying to start the server locally.

The server has been observed to not terminate specifically when using then --no-docker flag, although this is not 100% reproducible. Without the --no-docker flag we weren't able to reproduce this behaviour yet.

Worth noting: in #169 we bumped the usage of latest TechDocs common package, and use the default docker image provided by it

This is a follow-up from

Possibly related:

Expected Behavior

  • Run npx @techdocs/cli serve --no-docker or npx @techdocs/cli serve:mkdocs--no-docker
  • Abort command, or kill with SIGTERM
  • MkDocs server is not running anymore

Current Behavior

  • Run techdocs-cli serve --no-docker or techdocs-cli serve:mkdocs--no-docker
  • Abort command, or kill with SIGTERM
  • MkDocs server is still running, occasionally

Your Environment

  • TechDocs CLI version 0.8.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions