This repository was archived by the owner on Nov 19, 2021. It is now read-only.
bump usage of techdocs common package to latest version#169
Merged
ottosichert merged 11 commits intomainfrom Oct 13, 2021
Merged
bump usage of techdocs common package to latest version#169ottosichert merged 11 commits intomainfrom
ottosichert merged 11 commits intomainfrom
Conversation
Signed-off-by: Emma Indal <emmai@spotify.com>
Signed-off-by: Emma Indal <emmai@spotify.com>
Signed-off-by: Emma Indal <emmai@spotify.com>
🦋 Changeset detectedLatest commit: 073df46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
Looking into why the e2e test doesn't pass, as all the commands works without any probs when running locally. |
Member
Author
|
Looks like there is a problem with processes not being killed, as I get the error Edit: there was an additional problem too. I introduced the techdocs-core plugin which is not being installed so that was why it failed before, so installing techdocs-core now in the workflow. |
camilaibs
approved these changes
Oct 7, 2021
emmaindal
commented
Oct 12, 2021
ottosichert
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #92
This PR upgrades the techdocs common page to the latest version. Also falls back to the default docker image version if no docker image argument is passed through when running the command.