Skip to content

electron: fix potential loop with gpu-info-update #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

electron: fix potential loop with gpu-info-update #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/electron/src/main/attributes/GpuAttributeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,16 @@ export class GpuAttributeProvider implements BacktraceAttributeProvider {
private _attributes?: Record<string, unknown>;

constructor() {
// getGPUInfo may not be supported on earlier versions of Electron
if (!app.getGPUInfo) {
return;
}

app.on('gpu-info-update', () =>
// Collect this information only once
// getGPUInfo causes 'gpu-info-update' to be emitted again essentially causing a loop
// https://github.com/electron/electron/issues/30827
// It is unlikely to change again within runtime of the application
app.once('gpu-info-update', () =>
app
.getGPUInfo('complete')
.then((info) => {
Expand Down
Loading