Bugfix/next session breadcrumbs path #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlussenburg
approved these changes
Jul 4, 2022
perf2711
approved these changes
Jul 5, 2022
Runtime/Model/Breadcrumbs/Storage/BacktraceStorageLogManager.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We discovered a problem with breadcrumb support when we finished the previous session. If the game can't send errors on the next session startup because the game is delayed because of the startup jobs, then we probably won't have a breadcrumb file associated with the report. This diff makes a copy of the existing breadcrumb file on the session startup and replaces the old path to the breadcrumb file with a new one. In addition, this diff also delays possible breadcrumbs that backtrace-unity will store. Because of that, we're sure that we won't override the breadcrumb file before making a copy.
This diff is really similar to the diff that I already submitted while ago. In this diff I only focus on the breadcrumb problem and this diff doesn't touch initialization order - so it will be much safer to land if earlier.