Honor SOURCE_DATE_EPOCH#54
Merged
backtracking merged 1 commit intobacktracking:masterfrom Jan 6, 2017
roptat:master
Merged
Conversation
Owner
|
Thanks for this patch; it makes sense. |
Owner
|
I had to fix your patch using double quotes, as date sometimes uses
parentheses (e.g. (UTC+0100)) that result in a syntax error.
--
Jean-Christophe
…On 02/01/2017 17:54, roptat wrote:
Hi,
I'm trying to package ocamlgraph for GuixSD, my distribution of choice.
Like Debian and many others, we aim to have reproducible software.
Ocamlgraph embeds the compilation date and therefore isn't reproducible.
SOURCE_DATE_EPOCH is an environment variable that can be used by
distributors to set a fixed compilation date and obtain a reproducible
build. Its exact purpose is explained here:
https://reproducible-builds.org/specs/source-date-epoch/.
With this change, Guix doesn't complain about non-reproducibility
anymore, and it doesn't affect any user who don't care about
reproducibility.
Thank you :)
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#54
Commit Summary
* Honor SOURCE_DATE_EPOCH
File Changes
* *M* Makefile.in
<https://github.com/backtracking/ocamlgraph/pull/54/files#diff-0> (8)
Patch Links:
* https://github.com/backtracking/ocamlgraph/pull/54.patch
* https://github.com/backtracking/ocamlgraph/pull/54.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#54>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADWLtoHSClGER0IyR72RxclUI_5W00oBks5rOSvggaJpZM4LZHaK>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to package ocamlgraph for GuixSD, my distribution of choice. Like Debian and many others, we aim to have reproducible software. Ocamlgraph embeds the compilation date and therefore isn't reproducible. SOURCE_DATE_EPOCH is an environment variable that can be used by distributors to set a fixed compilation date and obtain a reproducible build. Its exact purpose is explained here: https://reproducible-builds.org/specs/source-date-epoch/.
With this change, Guix doesn't complain about non-reproducibility anymore, and it doesn't affect any user who don't care about reproducibility.
Thank you :)