require privileged mode for rsync-ssh mover

[tesshuflower]

Describe what this PR does

The older rsync mover over ssh always required elevated permissions, and this was allowed to avoid any breakages when movers were introduced that included un-elevated permissions by default.

Now enough time has passed where users should have migrated to the Rsync-TLS mover which does support unprivileged mode.

This change requires the privileged annotation on the namespace to be able to use the rsync ssh mover at all, aligning with the other movers where the annotation is required to run in privileged mode.

Is there anything that requires special attention?

Related issues:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.6%. Comparing base (2b90059) to head (91adde2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/controller/mover/rsync/mover.go	0.0%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #2087     +/-   ##
=======================================
- Coverage   68.7%   68.6%   -0.2%     
=======================================
  Files         58      58             
  Lines       6056    6058      +2     
=======================================
- Hits        4164    4158      -6     
- Misses      1581    1586      +5     
- Partials     311     314      +3     

Files with missing lines	Coverage Δ
internal/controller/mover/rsync/builder.go	91.7% <100.0%> (ø)
internal/controller/mover/rsync/mover.go	77.3% <0.0%> (-0.6%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tesshuflower]

/cc @JohnStrunk

Do you mind reviewing?

[JohnStrunk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment