[pull] master from darktable-org:master#874
Merged
Merged
Conversation
When `-d opencl -d perf` was active, the profiling summary could report absurd values like "spent 92233719808.0000 seconds in [Read Image (from device to host)]". The cause was that `dt_opencl_events_flush` computed `end - start` as `cl_ulong` (unsigned) without guarding against drivers that return `CL_SUCCESS` from `clGetEventProfilingInfo` while leaving the output untouched, querying profiling info for events that did not reach `CL_COMPLETE`, or otherwise yielding `end < start`. The unsigned underflow then wrapped to ~UINT64_MAX nanoseconds, which the aggregation turned into multi-billion-second figures. Initialize start/end, only query profiling info for events that completed cleanly, keep the `end >= start` sanity check, and emit a diagnostic identifying the offending tag, device, and raw timestamps when invalid data is encountered, so the underlying driver issue is surfaced rather than silently masked.
* colorspaces: release xprofile_lock on early return (Win32 ony)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )