test(examples): verify the published example CLI command end-to-end - #57
Merged
Conversation
tests/examples.test.js already covers the graph logic (parsePlan + buildGraph called directly), but nothing exercised the exact command examples/README.md tells a new dev to copy-paste (`node bin/parse-plan.js examples/hello-parallel/plan.md`). If the CLI's argument handling or JSON serialization ever diverged from the library functions, the unit test would stay green while the README's promised first-contact command silently broke. Added to the existing tests/parse-plan-cli.test.js rather than a new file, per the review that flagged this gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0145sjAtP5b5kvhR1XCgg3K3
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0145sjAtP5b5kvhR1XCgg3K3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from an external review of the v0.6.15-0.6.19 rollout — verified both flagged items against real code before acting:
assertAcyclicas evaluated-and-deferred): rested on a stale premise.assertAcyclicwas already made iterative in v0.6.15 (PR feat: engine limits (maxConcurrency, orphan-consumer warning, iterative assertAcyclic) #50) — it's not pending a decision, it's already shipped. Nothing to do here; the review's author appears to have analyzed an older state of the code.tests/examples.test.jsonly exercisedparsePlan/buildGraphdirectly; nothing ran the exact commandexamples/README.mdtells a new dev to copy-paste. Added one assertion to the existingtests/parse-plan-cli.test.js(per the review's own suggested alternative) instead of a new file.Version
0.6.19 → 0.6.20 (patch, pre-1.0
testrule)Test plan
node --test tests/parse-plan-cli.test.js— 4/4 passnpm test— 154/154 passhttps://claude.ai/code/session_0145sjAtP5b5kvhR1XCgg3K3