fix(desktop): keep the maximized pane's right-click menu available while a stream is connecting - #484
Merged
Merged
Conversation
…ile a stream is connecting In the maximized (full view) pane, the whole gesture stack, including onSecondaryTapDown -> _showMaximizedMenu, only rendered on the first-frame branch (_controller != null && _firstFrame). After a stream-quality switch (e.g. Data saver, whose on-demand mobile transcode spins up lazily) the pane sits in the spinner/warm-frame branch for a few seconds with NO gesture handler, so right-click silently did nothing and the user could not switch back or reach any menu action until the new stream delivered a frame. Wrap the spinner/warm-frame branch in a GestureDetector carrying the same onSecondaryTapDown (and double-click-to-close) as the live branch. Menu actions do not need a live controller. The wall tile is unaffected (its GestureDetector wraps the whole Stack). Found during v0.2.0 release testing. Signed-off-by: badbread <badbread@users.noreply.github.com>
…s runs Signed-off-by: badbread <badbread@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during v0.2.0 release testing: in full view (maximized pane), right-clicking after choosing Data saver did nothing until the stream came up — the menu was gone for the whole spin-up window.
Root cause: the maximized pane's entire gesture stack (including
onSecondaryTapDown -> _showMaximizedMenu) only rendered on the first-frame branch (_controller != null && _firstFrame). A quality switch tears the player down, and Data saver's on-demand mobile transcode spins up lazily, so the pane sits in the spinner/warm-frame branch for a few seconds with no gesture handler at all — right-click was silently dead, and you couldn't switch back.Fix: wrap the spinner/warm-frame branch in a
GestureDetectorcarrying the sameonSecondaryTapDown(and double-click-to-close). Menu actions don't need a live controller. The wall tile is unaffected (its GestureDetector wraps the whole Stack, so tile right-click already worked mid-reconnect).flutter analyze lib/ui/wall_screen.darton winbuild: No issues found!Part of the v0.2.0 testing batch.