Conversation
evert
reviewed
Sep 28, 2022
| PUBLIC_URI="http://localhost:8902/" | ||
|
|
||
| AUTH_API_URI=http://localhost:8531 | ||
| OAUTH2_CLIENT_ID= |
Collaborator
There was a problem hiding this comment.
You can probably pick a good default for this?
| "@curveball/router": "^0.4.1", | ||
| "@curveball/validator": "^0.9.0", | ||
| "dotenv": "^16.0.2", | ||
| "dotenv-defaults": "^5.0.2", |
Collaborator
There was a problem hiding this comment.
I regret adding dotenv-defaults to our other packages. I wonder if we should just remove these?
Contributor
Author
There was a problem hiding this comment.
I'm not opposed to it!
| @@ -1,3 +1,7 @@ | |||
| /* eslint-disable @typescript-eslint/no-var-requires */ | |||
| require('dotenv').config(); | |||
Collaborator
There was a problem hiding this comment.
It's possible now to do this with import and not require!
| user: 'tt', | ||
| password: 'password', | ||
| database: 'tt', | ||
| host: process.env.MYSQL_HOST, |
Collaborator
There was a problem hiding this comment.
Another thing that's worth testing is migrations. Do they run?
Contributor
Author
There was a problem hiding this comment.
they do not! hmmm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #21
Changes
dotenvanddotenv-defaults)knexfileTesting
Tested it by navigating the HAL browser, nothing broke!