Change to use the registration service that includes SemVer2 versions #11658
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11623
Problem
Shields is using the default
RegistrationsBaseUrlendpoint, which excludes SemVer2 packages. According to the NuGet API documentation, theRegistrationsBaseUrlresource has different versions with varying SemVer2 support:RegistrationsBaseUrl(default): SemVer 2.0.0 packages are excludedRegistrationsBaseUrl/3.4.0: SemVer 2.0.0 packages are excluded (but responses are gzip-compressed)RegistrationsBaseUrl/3.6.0: SemVer 2.0.0 packages are included (and responses are gzip-compressed)The Feedz.io service was calling
searchServiceUrl(baseUrl, 'RegistrationsBaseUrl'), which returned the default endpoint that excludes SemVer2 versions.Solution
Changed the service to request
RegistrationsBaseUrl/3.6.0instead ofRegistrationsBaseUrl. This ensures that SemVer2 versions are included in the API response, allowing the service to properly display them in badges.The modified method is only used by feedz.
The downside to this approach is that it takes quite a few requests and returns lots of extra data that is not needed, making it slower.
Testing
Running
npm run badge -- /feedz/vpre/xunit/xunit/xunit.v3:Before
After