Skip to content

refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew openvsx pepy poeditor winget] - #12093

Draft
jNullj wants to merge 5 commits into
badges:masterfrom
jNullj:improve-badges-patterns
Draft

refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew openvsx pepy poeditor winget]#12093
jNullj wants to merge 5 commits into
badges:masterfrom
jNullj:improve-badges-patterns

Conversation

@jNullj

@jNullj jNullj commented Aug 3, 2026

Copy link
Copy Markdown
Member

follow-up for #12090 (comment)

@jNullj jNullj added the core Server, BaseService, GitHub auth, Shared helpers label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Found badge URL that may not follow our standard route abbreviations in services/homebrew/homebrew-formula-downloads.service.js.
Please ensure you've reviewed our conventions.

⚠️

Found badge URL that may not follow our standard route abbreviations in services/winget/winget-release-date.service.js.
Please ensure you've reviewed our conventions.

⚠️

Found badge URL that may not follow our standard route abbreviations in services/open-vsx/open-vsx-release-date.service.js.
Please ensure you've reviewed our conventions.

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 52e58bd

@jNullj

jNullj commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

This turned out to reveal some services with routes that go against our conventions.
Should I create a follow-up PR after it's merged to update the routes and redirect the old ones?

@jNullj
jNullj marked this pull request as ready for review August 3, 2026 18:28
@jNullj jNullj changed the title refactor: migrate static prefix from route pattern to route base [clearly coderabbit conda crates github greasy homebrew nuget open-vsx pepy poeditor winget] refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget open-vsx pepy poeditor winget] Aug 3, 2026
@jNullj jNullj changed the title refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget open-vsx pepy poeditor winget] refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget openvsx pepy poeditor winget] Aug 3, 2026
@jNullj
jNullj marked this pull request as draft August 3, 2026 18:40
@jNullj jNullj changed the title refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget openvsx pepy poeditor winget] refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget openvsx pepy poeditor winget chocolatey powershellgallery resharper] Aug 3, 2026
@jNullj

jNullj commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

nuget family services will have issues when it come to test boilerplate as they have mixed tests endpoint in one path.
i will leave them out of this pr for now

@jNullj jNullj changed the title refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew nuget openvsx pepy poeditor winget chocolatey powershellgallery resharper] refactor: migrate static prefix from route pattern to route base [clearlydefined coderabbit conda crates github greasyfork homebrew openvsx pepy poeditor winget] Aug 3, 2026
@PyvesB

PyvesB commented Aug 9, 2026

Copy link
Copy Markdown
Member

Should I create a follow-up PR after it's merged to update the routes and redirect the old ones?

We could, though probably not super high priority. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Server, BaseService, GitHub auth, Shared helpers

Development

Successfully merging this pull request may close these issues.

2 participants