[BF-001] Replace the root language selector with a full x-default landing page - #92
Merged
Merged
Conversation
Deploying byteflow with
|
| Latest commit: |
c612500
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44f95b17.byteflow-c58.pages.dev |
| Branch Preview URL: | https://fix-bf-001-root-x-default-co.byteflow-c58.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #19
Scope
/x-default landing page requirements./crawlable and useful without a forced locale redirect.Implementation
src/app/page.tsxso/now has a full H1, value proposition, search entry, Browse all tools, Install app, free/no-account/local-first proof points, 8 popular tools, 8 category links, Privacy Policy, Trust Center, and language links.x-defaulthreflang on root via existing SEO helpers.site.root_*copy foren,zh-CN,zh-TW,ja,ko,de, andfr.tests/guards/root-page-redirect-guard.test.tsxto enforce no redirect script, complete root content, all locale alternates, indexable robots, and all-locale root copy coverage.Acceptance Criteria
/shows a full homepage, not a language-only interstitial./to a locale page./has canonical set tohttps://byteflow.tools/./hashreflang=\"x-default\"pointing tohttps://byteflow.tools/./has hreflang alternates foren,zh-CN,zh-TW,ja,ko,de, andfr./and all localized homepages are in sitemap.Validation
npm run lint- PASSnpm run test- PASS, 224 files / 1125 testsnpm run validate- PASS, including i18n, i18n QA, privacy copy, analytics taxonomy, security, bundle, SEO, and type gatesnpm run build- PASS, generated 1401 static pages; canonical/hreflang, metadata localization, JSON-LD, rendered i18n copy, localized content, and service worker post-build gates passednpm run test:e2e:smoke- PASSnpm run check:canonical- PASS, 1394 pages verifiednpm run check:hreflang- PASS, 1394 pages verifiednpm run check:sitemap-lastmod- PASSnpm run check:i18n- PASS; same-as-en effective count remains 0 for all non-en localesManual Checks
output/playwright/bf-001-root-desktop.png.output/playwright/bf-001-root-mobile.png.output/playwright/bf-001-root-evidence.json.canonical=https://byteflow.tools,alternateCount=8,x-default=https://byteflow.tools,h1=123 Local Browser Tools for Developers.Privacy Check
Screenshots / Evidence
output/playwright/bf-001-root-desktop.pngoutput/playwright/bf-001-root-mobile.pngoutput/playwright/bf-001-root-evidence.json