Upgrade MongoDB drivers to the latest 3.2 version#480
Upgrade MongoDB drivers to the latest 3.2 version#480luislobo wants to merge 64 commits intobalderdashy:masterfrom
Conversation
luislobo
commented
Mar 24, 2019
luislobo
commented
- [COMPATIBILITY] Upgrade mongodb driver to the latest version. For more information about breaking changes, check the README.md file
- [DEPENDENCIES] Updates other dependencies to the latest available
- [TEST] Travis now run tests on current Node LTS versions: 6, 8, 10, and MongoDB 3.4, 3.6, 4.0
It was working under Linux, but under Windows it was failing. Fixed so that it actually works anywhere
… some tests are taking longer
mikermcneil
left a comment
mikermcneil
left a comment
There was a problem hiding this comment.
@luislobo amazing work, thank you! See one of my readme comments for the main thing to look into-- the rest of the stuff is more about clarifying docs and some annoying markdown consistency nits (apologies in advance)
luislobo
left a comment
luislobo
left a comment
There was a problem hiding this comment.
@mikermcneil I've made some changes as suggested. Please let me know any other change as needed.
…pared to just downloading the archive
Replace the name of the internal variable that holds the database, from _WPdb, to _sailsDbInstance, for better readability
Because of the change of what a manager is, we need to check if the manager is a MongoClient or not balderdashy/sails-mongo#480
luislobo
left a comment
luislobo
left a comment
There was a problem hiding this comment.
@mikermcneil @rachaelshaw I've just finished all my changes and updates here. Should be good for a review
|
Well, tests are failing in travis and appveyor... They don't fail on my local, I'll double check all |
|
Any news on this PR? |
|
Any help needed here? We should merge this PR and update the sails-mongo npm package, the 3.4 mongo version support is gonna end up this month. |
|
First, thanks for the great work on this adapter. We would love to see this PR get merged. As Mongo 3.4 hits end-of-life this month (January 2020), we are planning to upgrade to Mongo 4.0 then 4.2. Our Sails application will fail without being able to get this version of the Mongo adapter. Thanks. And if I can help somehow, do let me know. |
|
hey @marckhouzam take a look here: balderdashy/sails#6899 |
|
I have made an independent quick fix for sails-mongo to work with the latest nodejs module mongodb-3.5.2 which will support MongoDB 4. Make sure your mongodb nodejs module is updated to 3.5.2. Any errors please let me know. |
|
Closed in favor of @Josebaseba PR: #483 Will send some updates to that PR that adds missing connection options validations, updates README, and some things here and there |
8 participants
