Skip to content

[patch] Several improvements to the test environment#485

Merged
mikermcneil merged 4 commits intobalderdashy:masterfrom
luislobo:update-test-environment
Jun 13, 2020
Merged

[patch] Several improvements to the test environment#485
mikermcneil merged 4 commits intobalderdashy:masterfrom
luislobo:update-test-environment

Conversation

@luislobo
Copy link
Copy Markdown
Contributor

@luislobo luislobo commented Jun 13, 2020

The idea here is to make sure the testing environment has the latest current and supported versions of Node and MongoDB.

With this, we can better review and clean up the other PRs associated to MongoDB driver upgrades.

My original PR (#480) includes these changes. My intention is to separate that PR into two. This one should be addressed first.

Once this is done, the driver upgrade review would be easier.

My plan is to include/review all the driver PRs that have been proposed and create one based of them:

I'd appreciate the eyes of @mikermcneil, @Josebaseba

  • [ENHANCEMENT] Adds npm run start-mongodb and npm run stop-mongodb scripts to start/stop a MongoDB docker instance

  • [ENHANCEMENT] Adds npm run mongodb-shell to run a MongoDB Shell CLI that connects to the MongoDB docker instance

  • [INTERNAL] Bump and pin dependency versions

  • [INTERNAL] Tests in Travis run against a combination of Node.js 10, 12, 14 and MongoDB: 3.6, 4.0, 4.2

  • [INTERNAL] Refactors docker-compose.yml, removing the need of Dockerfile. Updates Docker node version to 12, and MongoDB to 4.2

…mbinations

* [ENHANCEMENT] Adds `npm run start-mongodb` and `npm run stop-mongodb` scripts to start/stop a MongoDB docker instance

* [ENHANCEMENT] Adds `npm run mongodb-shell` to run a MongoDB Shell CLI that connects to the MongoDB docker instance
* [INTERNAL] Bump and pin dependency versions
* [INTERNAL] Tests in Travis run against a combination of Node.js 10, 12, 14 and MongoDB: 3.6, 4.0, 4.2
* [INTERNAL] Refactors docker-compose.yml, removing the need of Dockerfile. Updates Docker node version to 12, and MongoDB to 4.2
Adds branch name for Travis to run tests on this branch
@sailsbot
Copy link
Copy Markdown
Collaborator

Hi @luislobo! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

@luislobo luislobo changed the title Several improvements to the test environment [patch] Several improvements to the test environment Jun 13, 2020
@sailsbot
Copy link
Copy Markdown
Collaborator

Thanks for submitting this pull request, @luislobo! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

Comment thread .travis.yml
- tar xzf mongodb-linux-x86_64-${MONGODB}.tgz
- ${PWD}/mongodb-linux-x86_64-${MONGODB}/bin/mongod --version
- npm install
# Don't let npm send metrics as it creates a file in the .npm folder invalidating the cache every time
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikermcneil
Copy link
Copy Markdown
Member

oh shit this one sparkles

clearly written by a guy in a suit
image

@mikermcneil mikermcneil merged commit aff5b3b into balderdashy:master Jun 13, 2020
@luislobo
Copy link
Copy Markdown
Contributor Author

clearly written by a guy in a suit

hahah, after I saw the commits were all done under the company "email" I was like... whatever! Gravatar is going to have some fun

@luislobo luislobo deleted the update-test-environment branch June 14, 2020 03:09
@mikermcneil
Copy link
Copy Markdown
Member

balderdashy/sails#6899

@marckhouzam
Copy link
Copy Markdown

Hi @luislobo. I'm trying to figure out if a released version of the adapter works with Mongo 4.0 and 4.2. This PR updated the README to say the adapter is being tested with 4.0 and 4.2 (🎉 ), however there hasn't been a release that includes your changes.

It was not clear to me if the 1.2 release itself also supported Mongo 4.0/4.2?
Could someone clarify?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants