[patch] Several improvements to the test environment#485
[patch] Several improvements to the test environment#485mikermcneil merged 4 commits intobalderdashy:masterfrom
Conversation
…mbinations * [ENHANCEMENT] Adds `npm run start-mongodb` and `npm run stop-mongodb` scripts to start/stop a MongoDB docker instance * [ENHANCEMENT] Adds `npm run mongodb-shell` to run a MongoDB Shell CLI that connects to the MongoDB docker instance * [INTERNAL] Bump and pin dependency versions * [INTERNAL] Tests in Travis run against a combination of Node.js 10, 12, 14 and MongoDB: 3.6, 4.0, 4.2 * [INTERNAL] Refactors docker-compose.yml, removing the need of Dockerfile. Updates Docker node version to 12, and MongoDB to 4.2 Adds branch name for Travis to run tests on this branch
|
Hi @luislobo! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with |
|
Thanks for submitting this pull request, @luislobo! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
(and also test if Travis is caching MongoDB binaries)
| - tar xzf mongodb-linux-x86_64-${MONGODB}.tgz | ||
| - ${PWD}/mongodb-linux-x86_64-${MONGODB}/bin/mongod --version | ||
| - npm install | ||
| # Don't let npm send metrics as it creates a file in the .npm folder invalidating the cache every time |
hahah, after I saw the commits were all done under the company "email" I was like... whatever! Gravatar is going to have some fun |
|
Hi @luislobo. I'm trying to figure out if a released version of the adapter works with Mongo 4.0 and 4.2. This PR updated the README to say the adapter is being tested with 4.0 and 4.2 (🎉 ), however there hasn't been a release that includes your changes. It was not clear to me if the 1.2 release itself also supported Mongo 4.0/4.2? Thanks! |

The idea here is to make sure the testing environment has the latest current and supported versions of Node and MongoDB.
With this, we can better review and clean up the other PRs associated to MongoDB driver upgrades.
My original PR (#480) includes these changes. My intention is to separate that PR into two. This one should be addressed first.
Once this is done, the driver upgrade review would be easier.
My plan is to include/review all the driver PRs that have been proposed and create one based of them:
I'd appreciate the eyes of @mikermcneil, @Josebaseba
[ENHANCEMENT] Adds
npm run start-mongodbandnpm run stop-mongodbscripts to start/stop a MongoDB docker instance[ENHANCEMENT] Adds
npm run mongodb-shellto run a MongoDB Shell CLI that connects to the MongoDB docker instance[INTERNAL] Bump and pin dependency versions
[INTERNAL] Tests in Travis run against a combination of Node.js 10, 12, 14 and MongoDB: 3.6, 4.0, 4.2
[INTERNAL] Refactors docker-compose.yml, removing the need of Dockerfile. Updates Docker node version to 12, and MongoDB to 4.2